Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search] Fixes the theme for the editor on the dark mode #137680

Merged
merged 1 commit into from
Aug 2, 2022
Merged

[Unified search] Fixes the theme for the editor on the dark mode #137680

merged 1 commit into from
Aug 2, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 1, 2022 •
edited by kibanamachine
Loading

Summary

Part of #136950
Fixes the theme of the editor on the dark mode.

image

@stratoula stratoula added Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes Feature:Unified search Unified search related tasks backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.4.0 v8.5.0 labels Aug 1, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 227.9KB 228.0KB +102.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review August 1, 2022 11:26
@stratoula stratoula requested a review from a team as a code owner August 1, 2022 11:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@stratoula stratoula mentioned this pull request Aug 1, 2022
Closed
8 tasks
@stratoula stratoula merged commit 514e5a7 into elastic:main Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@stratoula
[Unified search] Fixes the theme for the editor on the dark mode (ela…
936b286 
…stic#137680)

(cherry picked from commit 514e5a7)
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 2, 2022
@kibanamachine @stratoula
[Unified search] Fixes the theme for the editor on the dark mode (#13…
b3a6b46 
…7680) (#137854)

(cherry picked from commit 514e5a7)

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Unified search Unified search related tasks release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @kibana-ci @elasticmachine @kibanamachine @jloleysens