[Discover][Unified search] Enable text based queries - Follow ups

[stratoula]

Here is a list of remaining things that need to be done / investigated for the SQL in Discover feature

• Change the error state to be closer on the design mockups, field list should be hidden when dataview is not found https://whimsical.com/wireframes-v3-esql-HYqLYJgDKhKeioAUxRSjKD (have to talk with design team first and do something that makes sense for Lens too)

• Monaco investigation:

  • Why undo is broken? Fixed!
  • Scrollbar should be visible only when the editor’s height is greater than the maximum height - [Discover][Unified search] Scrollbar visibility only when the editor’s height is greater than the maximum height #148150
  • Clicking on an individual error should focus the error on the monaco editor (check the above mentioned wireframes) - [Discover][Unified Search] Clicking on an individual error should focus the error on the monaco editor. #148171

• When you are on the initial view (editor is hidden) and you click somewhere in the query (not in the end but somewhere else) the cursor is not set at the correct position)
  

• Navigating from SQL mode to dataview mode by clicking the Discover breadcrumb should open the warning modal

• It's possible to save a saved search, build a vis on it, then switch it to sql and save it again. The panel then fails like this:

This could be fixed by "forgetting" the current saved search when switching to/from SQL mode.

Blocked by #132620

Design

• Resize on expanded mode - [Unified Search] Sql editor border fix on resize. #148198
  • During a resize action, the gray border above the editor footer disappears.
  • During a resize action, if an invalid border is present on the editor, it temporarily turns from a 2px border to a 1px border. After stopping the resize action, it correctly returns to 2px after a few seconds.
    The above 2 are related. I think it happens due to monaco height update. I am not sure if removing the borders and adding background gradients can fix it (check EUI inputs)
• The theme we picked is not dark mode perfect. [Unified search] Fixes the theme for the editor on the dark mode #137680
• Resizer used is custom made because with the current architecture we cant use the EuiResizablePanel. There are 2 solutions:
  • Refactor the unified component's structure as Joe proposes here [Discover] Supports SQL query language (#134429) #136702 (comment)
  • Export the Resizable button from the EUI and use it with my custom solution
  • Copy paste the styles from EUI [Unified search] Make resizable button as the EUI one #137698

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[ghudgins]

when we remove new lines to be 'collapsed' we also run the risk of bumping the lines together and losing the syntax highlighting. might be good to replace each new line with a space visually in collapsed mode so we don't get loss of monaco highlighting. see ORDER in the below example

full gif -

[stratoula]

@ghudgins the bug mentioned above has been fixed and merged to main(release v8.5)

[ninoslavmiskovic]

@stratoula Can we close this one ?

[stratoula]

Yes I will close it as the majority of them have been fixed and there are follow up issues for the others