Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Make the Cancel Snooze button skip the current recurrence #136430

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jul 14, 2022

Summary

Part of #132860. This updates the backend to allow the Cancel Snooze button to skip the currently active recurrence of a snooze, while keeping future recurrences of that snooze schedule intact.

This does NOT incorporate the UI changes in #132860. These will merge in a later PR.

To test

  • Schedule a snooze that starts NOW and recurs every day/week/etc
  • Refresh the page, press the Cancel Snooze button
  • Ensure that the current snooze is cancelled but the snooze schedule still exists

Checklist

@Zacqary Zacqary added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.4.0 labels Jul 14, 2022
@Zacqary Zacqary marked this pull request as ready for review July 14, 2022 18:49
@Zacqary Zacqary requested a review from a team as a code owner July 14, 2022 18:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 18, 2022

@elasticmachine merge upstream

@Zacqary Zacqary enabled auto-merge (squash) July 18, 2022 17:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 356 357 +1

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
alert 74 75 +1
Unknown metric groups

API count

id before after diff
alerting 365 366 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 92ee5dc into elastic:main Jul 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants