-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] Make the Cancel Snooze button skip the current recurrence #132860
Comments
Pinging @elastic/response-ops (Team:ResponseOps) |
@mdefazio we should talk about a solution here? it seems confusing when we have multiple schedules to be cancel |
@XavierM Yeah, we knew this was coming. We had planned on a modal asking to confirm which choice (only current schedule, or all future schedules). I will add some wireframes to the issue. The other, somewhat related scenario which is currently possible (that may require larger changes) is if I choose to apply the 15 hour relative snooze from the above screenshot UI. There would then be a scheduled snooze (say Tuesdays at 5pm and then a relative snooze for the next 15 hours). This presents some extra complexity. The other potential scenario is if I have two overlapping schedules...we would then need to have them choose or have the 'Cancel current' option apply to both. |
Imo it should apply to both. Can't imagine a case where a user wants to unsnooze their "Every Tuesday" snooze but keep their ad-hoc snooze active And like, if you do want to do that for some reason? Then like. My dude. Maybe you should not be configuring things so complicated. |
After discussing with @XavierM and @Zacqary, we opted for a straightforward experience here that simply cancels all schedules/snoozes. We acknowledge there may be scenarios that someone will want to cancel only one of the scheduled snoozes. But the level of effort to fix an undesired result at this time seems acceptable. Once we have a more scalable snoozing solution, we will want to revisit this. Summary: No change if only a relative snooze is active, or multiple schedule snoozes are assigned but only one is currently active. Screenshot of Whimsical diagram Enlarged modal for copy reference:
The copy could be better perhaps... @lcawl Do you mind taking a quick glance? |
I'm realizing this will require a minor addition to the SavedObject schema, as RRULE doesn't support something like "recur every x weeks, except for this date." Something like a |
Waiting on #136148 to provide a model for determining a rule's EDIT: Never mind, found a way to do it in parallel to that other PR |
Consider the following example:
This rule snoozes
Every week on Tuesday
. Let's say I'm looking at it on a Tuesday and I want to skip this week, but I don't want to delete the whole schedule.As a user, I expect the Cancel Snooze button to re-enable notifications this week, but to disable them next week. Currently, clicking this button will do nothing in this scenario.
This will probably require adding something to a data model somewhere. We can pull the current
snoozeEndTime
for an active snooze, so we should be able to tell the task manager that a given snoozeScheduleid
should not actually snooze anything until after thatsnoozeEndTime
.The text was updated successfully, but these errors were encountered: