-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Adds dry_run for bulk edit and UX handle for bulk edit of ML rule index #134664
[Security Solution][Detections] Adds dry_run for bulk edit and UX handle for bulk edit of ML rule index #134664
Conversation
…com/vitaliidm/kibana into security-solution/bulk-edit-dry-run
…com/vitaliidm/kibana into security-solution/bulk-edit-dry-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
…_action API (#2210) Adds dry_run mode description to _bulk_action API Preview [here](https://security-docs_2210.docs-preview.app.elstc.co/guide/en/security/master/bulk-actions-rules-api.html). - issue elastic/kibana#125512 - PR elastic/kibana#134664
…_action API (#2210) Adds dry_run mode description to _bulk_action API Preview [here](https://security-docs_2210.docs-preview.app.elstc.co/guide/en/security/master/bulk-actions-rules-api.html). - issue elastic/kibana#125512 - PR elastic/kibana#134664 (cherry picked from commit 14f75a2)
…_action API (#2210) (#2239) Adds dry_run mode description to _bulk_action API Preview [here](https://security-docs_2210.docs-preview.app.elstc.co/guide/en/security/master/bulk-actions-rules-api.html). - issue elastic/kibana#125512 - PR elastic/kibana#134664 (cherry picked from commit 14f75a2) Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
Summary
Addresses:
Implemented
dry_run
to _bulk_action API, that allows simulate bulk action without actually updating rules. More details in the ticketBefore displaying modal window, dry_run bulk action request will be send to get information how many rules can be edited. Based on this result, modal window displays how many rules can be edited and how many can't(with displaying error of validation). Users then can proceed to edit rules, that haven't failed during dry run.
Validation errors include at this point
Before
Error displayed when user tried to apply index pattern action to ML rule
Screen.Recording.2022-06-23.at.16.53.10.mov
After
Modal window is displayed with message that index pattern action can't be applied to ML rule
dry_run_1.mov
Follow-ups:
Once merged, create PR for Security Solution API documentation
Checklist
Delete any items that are not applicable to this PR.
Release note