Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Bulk action handling for detection rules #2209

Closed
joepeeples opened this issue Jul 19, 2022 · 1 comment · Fixed by #2328
Closed

[DOCS] Bulk action handling for detection rules #2209

joepeeples opened this issue Jul 19, 2022 · 1 comment · Fixed by #2328

Comments

@joepeeples
Copy link
Contributor

joepeeples commented Jul 19, 2022

Description

PR elastic/kibana#134664 enhances handling for bulk actions applied to both prebuilt and custom rules. If an action can't be performed because some of the selected rules are prebuilt rules, the error messaging and confirmation notifications will account for this, instead of a blanket error.

Also review the UI copy added, and follow up with any feedback (separate issue, ping team directly, etc.).

Notes

  • Demo of this feature included index patterns and exporting. Tags are probably also involved.
  • Several of the new modals/toasts appear to capitalize "Custom rules" but should probably be lowercase.
@banderror
Copy link
Contributor

If an action can't be performed because some of the selected rules are prebuilt rules, the error messaging and confirmation notifications will account for this, instead of a blanket error.

@joepeeples To be precise, even before elastic/kibana#134664 we were showing this modal window instead of running a bulk action that would end up with errors. You can compare the "Before" and "After" in the PR description. What the PR introduced is 2 things:

  • Added proper handling for machine learning rules. Before the PR, if the user selected some custom machine learning rules and tried to edit their index patterns, we would allow them to do that and it would end up with an error. After the PR, we show this modal window where we tell them that they can't edit index patterns for machine learning rules. This is a visual change.
  • Added this dry_run mode which is a technical improvement for our bulk editing implementation in the app. That's internal change.

Several of the new modals/toasts appear to capitalize "Custom rules" but should probably be lowercase.

This has been done in elastic/kibana#138077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants