[Actionable Observability] update alerts table rule details link to point to o11y rule detail page #132479

mgiota · 2022-05-18T21:00:35Z

…-ref HEAD~1..HEAD --fix'

…ition

mgiota · 2022-05-19T06:57:20Z

x-pack/test/observability_functional/apps/observability/alerts/index.ts

@@ -223,7 +223,9 @@ export default ({ getService }: FtrProviderContext) => {
          const actionsButton = await observability.alerts.common.getActionsButtonByIndex(0);
          await actionsButton.click();
          await observability.alerts.common.viewRuleDetailsButtonClick();
-          expect(await find.existsByCssSelector('[title="Rules and Connectors"]')).to.eql(true);
+          expect(await find.existsByCssSelector('[data-test-subj="ruleDetailPageTitle"]')).to.eql(


@fkanout Currently there's a problem with current test which keeps failing because as you can see in the screenshot rule is undefined (you can even see it in the breadcrumb) and rule details page can not be loaded.
Here's where rule is undefined https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability/public/pages/rule_details/index.tsx#L201. Stack Management Rule details page is getting the rule as param https://github.com/elastic/kibana/blob/main/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx#L76 and I guess that's why the old rule detail page loads in the tests without issues. This refactoring is out of scope of this issue. How do you suggest we proceed with this failing test?

Alternatively I could assert in my test if the page title contains Rules - Alerts - Observability, or even check the rendered breadcrumb if it contains Observability. What do you think? All we want to check with this test, is that it goes to the new Obsservability rule detail page and not the old Rules and Connectors page.

I just pushed a fix that checks if Observability is in the breadcrumb 1f94a1f#diff-5a75bdfd91813e385e6c322eed601a2fd55d34f4a56b7669b0bb193014df1648R226

@mgiota, I think this ok for the purpose of this test and in the scope of this PR.

fkanout

LGTM. Tested, and it worked as expected. Thank you for spotting the need for these changes!
One suggestion about using the URL var instead of the hardcoded one

fkanout · 2022-05-19T11:14:23Z

x-pack/plugins/observability/public/config/paths.ts

@@ -8,6 +8,7 @@
 export const paths = {
  observability: {
    alerts: '/app/observability/alerts',
+    ruleDetails: (ruleId: string) => `/app/observability/alerts/rules/${encodeURI(ruleId)}`,


What do you think of using this var for the URL https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability/public/pages/rule_details/config.ts#L22?

Yep great suggestion! I'll change it

fkanout · 2022-05-19T11:14:27Z

x-pack/plugins/observability/public/pages/alerts/components/alerts_flyout/alerts_flyout.tsx

-  const linkToRule = ruleId && prepend ? prepend(paths.management.ruleDetails(ruleId)) : null;
-
+  const linkToRule =
+    ruleId && prepend ? prepend(`/app/observability/alerts/rules/${ruleId}`) : null;


Same here https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability/public/pages/rule_details/config.ts#L22 ?

@fkanout I'll move your variables in the paths file, which is a common place in observability plugin and refactor accordingly

…-ref HEAD~1..HEAD --fix'

mgiota · 2022-05-19T13:42:40Z

I moved the variables in the common paths file and I refactored following places to make use of it in following places:

rule details link in alerts table
rule details link in alerts flyout
rules details link in rules page
rules link and alerts link in rule details page

kibana-ci · 2022-05-19T14:50:35Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #2

Test Failures

[job] [logs] FTR Configs #2 / lens app - group 1 lens query context keeps time range and pinned filters after refreshing directly after saving

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	452.0KB	452.1KB	+192.0B

History

💚 Build #46028 succeeded 1f94a1f
💔 Build #45994 failed 8283952
💔 Build #45946 failed d09f583

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

update alerts table rule details link to point to o11y rule detail page

7ed2e65

mgiota requested a review from a team as a code owner May 18, 2022 21:00

mgiota changed the title ~~update alerts table rule details link to point to o11y rule detail page~~ [Actionable Observability] update alerts table rule details link to point to o11y rule detail page May 18, 2022

mgiota self-assigned this May 18, 2022

mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 release_note:skip Skip the PR/issue when compiling release notes labels May 18, 2022

kibanamachine and others added 2 commits May 18, 2022 21:06

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

f4bc71d

…-ref HEAD~1..HEAD --fix'

o11y alert flyout should also link to o11y rule details page

400c613

mgiota force-pushed the 132389_rule_details_o11y_link branch from 27935b9 to 400c613 Compare May 18, 2022 21:28

kibanamachine and others added 2 commits May 18, 2022 21:33

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

d09f583

…-ref HEAD~1..HEAD --fix'

add data-test-subj to rule details page title and add move path defin…

8283952

…ition

mgiota commented May 19, 2022

View reviewed changes

mgiota requested a review from fkanout May 19, 2022 07:00

fix failing tests by checking existance of Observability in breadcrumb

1f94a1f

fkanout approved these changes May 19, 2022

View reviewed changes

mgiota and others added 3 commits May 19, 2022 15:10

use alerts and rules link from the paths file

3851dee

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

72ad27f

…-ref HEAD~1..HEAD --fix'

update link in alert flyout to use paths

b4e82ef

mgiota force-pushed the 132389_rule_details_o11y_link branch from 6952f3c to b4e82ef Compare May 19, 2022 13:27

update rule details link in the rules page

5c682be

mgiota merged commit 483cc45 into elastic:main May 19, 2022

kibanamachine added the backport:skip This commit does not require backporting label May 19, 2022

mgiota mentioned this pull request Jun 2, 2022

[Actionable Observability] Add functional tests for the Rule Details page #133271

Merged

1 task

mgiota mentioned this pull request Jul 6, 2022

[Actionable Observability] Fix rule's link in observability cases #134822

Merged

1 task

mgiota deleted the 132389_rule_details_o11y_link branch September 29, 2023 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actionable Observability] update alerts table rule details link to point to o11y rule detail page #132479

[Actionable Observability] update alerts table rule details link to point to o11y rule detail page #132479

mgiota commented May 18, 2022

mgiota May 19, 2022 •

edited

Loading

mgiota May 19, 2022 •

edited

Loading

mgiota May 19, 2022

fkanout May 19, 2022

fkanout left a comment

fkanout May 19, 2022

mgiota May 19, 2022

fkanout May 19, 2022

mgiota May 19, 2022 •

edited

Loading

mgiota commented May 19, 2022 •

edited

Loading

kibana-ci commented May 19, 2022

[Actionable Observability] update alerts table rule details link to point to o11y rule detail page #132479

[Actionable Observability] update alerts table rule details link to point to o11y rule detail page #132479

Conversation

mgiota commented May 18, 2022

mgiota May 19, 2022 • edited Loading

Choose a reason for hiding this comment

mgiota May 19, 2022 • edited Loading

Choose a reason for hiding this comment

mgiota May 19, 2022

Choose a reason for hiding this comment

fkanout May 19, 2022

Choose a reason for hiding this comment

fkanout left a comment

Choose a reason for hiding this comment

fkanout May 19, 2022

Choose a reason for hiding this comment

mgiota May 19, 2022

Choose a reason for hiding this comment

fkanout May 19, 2022

Choose a reason for hiding this comment

mgiota May 19, 2022 • edited Loading

Choose a reason for hiding this comment

mgiota commented May 19, 2022 • edited Loading

kibana-ci commented May 19, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

mgiota May 19, 2022 •

edited

Loading

mgiota May 19, 2022 •

edited

Loading

mgiota May 19, 2022 •

edited

Loading

mgiota commented May 19, 2022 •

edited

Loading