add data-test-subj to rule details page title and add move path defin…

…ition
elastic · May 19, 2022 · 8283952 · 8283952
1 parent d09f583
commit 8283952
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/x-pack/plugins/observability/public/config/paths.ts b/x-pack/plugins/observability/public/config/paths.ts
@@ -8,6 +8,7 @@
 export const paths = {
   observability: {
     alerts: '/app/observability/alerts',
+    ruleDetails: (ruleId: string) => `/app/observability/alerts/rules/${encodeURI(ruleId)}`,
   },
   management: {
     rules: '/app/management/insightsAndAlerting/triggersActions/rules',

diff --git a/.../observability/public/pages/alerts/containers/alerts_table_t_grid/alerts_table_t_grid.tsx b/.../observability/public/pages/alerts/containers/alerts_table_t_grid/alerts_table_t_grid.tsx
@@ -65,7 +65,7 @@ import { useGetUserCasesPermissions } from '../../../../hooks/use_get_user_cases
 import { usePluginContext } from '../../../../hooks/use_plugin_context';
 import { LazyAlertsFlyout } from '../../../..';
 import { parseAlert } from '../../components/parse_alert';
-import { translations } from '../../../../config';
+import { translations, paths } from '../../../../config';
 import { addDisplayNames } from './add_display_names';
 import { ADD_TO_EXISTING_CASE, ADD_TO_NEW_CASE } from './translations';
 import { ObservabilityAppServices } from '../../../../application/types';
@@ -170,10 +170,7 @@ function ObservabilityActions({
 
   const casePermissions = useGetUserCasesPermissions();
   const ruleId = alert.fields['kibana.alert.rule.uuid'] ?? null;
-  const linkToRule = ruleId
-    ? http.basePath.prepend(`/app/observability/alerts/rules/${ruleId}`)
-    : null;
-
+  const linkToRule = ruleId ? http.basePath.prepend(paths.observability.ruleDetails(ruleId)) : null;
   const caseAttachments: CaseAttachments = useMemo(() => {
     return ecsData?._id
       ? [

diff --git a/x-pack/plugins/observability/public/pages/rule_details/index.tsx b/x-pack/plugins/observability/public/pages/rule_details/index.tsx
@@ -210,7 +210,7 @@ export function RuleDetailsPage() {
   return (
     <ObservabilityPageTemplate
       pageHeader={{
-        pageTitle: <PageTitle rule={rule} />,
+        pageTitle: <PageTitle data-test-subj="ruleDetailPageTitle" rule={rule} />,
         bottomBorder: false,
         rightSideItems: hasEditButton
           ? [

diff --git a/x-pack/test/observability_functional/apps/observability/alerts/index.ts b/x-pack/test/observability_functional/apps/observability/alerts/index.ts
@@ -223,7 +223,9 @@ export default ({ getService }: FtrProviderContext) => {
           const actionsButton = await observability.alerts.common.getActionsButtonByIndex(0);
           await actionsButton.click();
           await observability.alerts.common.viewRuleDetailsButtonClick();
-          expect(await find.existsByCssSelector('[title="Rules and Connectors"]')).to.eql(true);
+          expect(await find.existsByCssSelector('[data-test-subj="ruleDetailPageTitle"]')).to.eql(
+            true
+          );
         });
       });