[Cases] Show deprecated icon in connectors with isDeprecated true

x-pack/plugins/actions/common/types.ts

@@ -35,6 +35,7 @@ export interface ActionResult {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   config: Record<string, any>;
   isPreconfigured: boolean;
+  isDeprecated?: boolean;
 }
 
 // the result returned from an action type executor function

x-pack/plugins/cases/public/components/configure_cases/connectors_dropdown.test.tsx

@@ -269,4 +269,26 @@ describe('ConnectorsDropdown', () => {
     );
     expect(tooltips[0]).toBeInTheDocument();
   });
+
+  test('it shows the deprecated tooltip when the connector is deprecated by configuration', () => {
+    const connector = connectors[0];
+    render(
+      <ConnectorsDropdown
+        {...props}
+        connectors={[
+          {
+            ...connector,
+            isDeprecated: true,
+          },
+        ]}
+        selectedConnector={connector.id}
+      />,
+      { wrapper: ({ children }) => <TestProviders>{children}</TestProviders> }
+    );
+
+    const tooltips = screen.getAllByText(
+      'This connector is deprecated. Update it, or create a new one.'
+    );
+    expect(tooltips[0]).toBeInTheDocument();
+  });
 });

x-pack/plugins/cases/public/components/utils.test.ts

@@ -46,53 +46,23 @@ describe('Utils', () => {
       config: { usesTableApi: false },
       secrets: {},
       isPreconfigured: false,
+      isDeprecated: false,
     };
 
     it('returns false if the connector is not defined', () => {
       expect(isDeprecatedConnector()).toBe(false);
     });
-
-    it('returns false if the connector is not ITSM or SecOps', () => {
-      expect(isDeprecatedConnector(connector)).toBe(false);
-    });
-
-    it('returns false if the connector is .servicenow and the usesTableApi=false', () => {
-      expect(isDeprecatedConnector({ ...connector, actionTypeId: '.servicenow' })).toBe(false);
+    it('returns false if the connector is marked as deprecated', () => {
+      expect(isDeprecatedConnector({ ...connector, isDeprecated: false })).toBe(false);
     });
 
-    it('returns false if the connector is .servicenow-sir and the usesTableApi=false', () => {
-      expect(isDeprecatedConnector({ ...connector, actionTypeId: '.servicenow-sir' })).toBe(false);
+    it('returns true if the connector is marked as deprecated', () => {
+      expect(isDeprecatedConnector({ ...connector, isDeprecated: true })).toBe(true);
     });
-
-    it('returns true if the connector is .servicenow and the usesTableApi=true', () => {
+    it('returns true if the connector is marked as deprecated (preconfigured connector)', () => {
       expect(
-        isDeprecatedConnector({
-          ...connector,
-          actionTypeId: '.servicenow',
-          config: { usesTableApi: true },
-        })
+        isDeprecatedConnector({ ...connector, isDeprecated: true, isPreconfigured: true })
       ).toBe(true);
     });
-
-    it('returns true if the connector is .servicenow-sir and the usesTableApi=true', () => {
-      expect(
-        isDeprecatedConnector({
-          ...connector,
-          actionTypeId: '.servicenow-sir',
-          config: { usesTableApi: true },
-        })
-      ).toBe(true);
-    });
-
-    it('returns false if the connector preconfigured', () => {
-      expect(isDeprecatedConnector({ ...connector, isPreconfigured: true })).toBe(false);
-    });
-
-    it('returns false if the config is undefined', () => {
-      expect(
-        // @ts-expect-error
-        isDeprecatedConnector({ ...connector, config: undefined })
-      ).toBe(false);
-    });
   });
 });

x-pack/plugins/cases/public/components/utils.ts

@@ -74,26 +74,5 @@ export const getConnectorIcon = (
 
 // TODO: Remove when the applications are certified
 export const isDeprecatedConnector = (connector?: CaseActionConnector): boolean => {
-  /**
-   * It is not possible to know if a preconfigured connector
-   * is deprecated or not as the config property of a
-   * preconfigured connector is not returned by the
-   * actions framework
-   */
-  if (connector == null || connector.config == null || connector.isPreconfigured) {
-    return false;
-  }
-
-  if (connector.actionTypeId === '.servicenow' || connector.actionTypeId === '.servicenow-sir') {
-    /**
-     * Connector's prior to the Elastic ServiceNow application
-     * use the Table API (https://developer.servicenow.com/dev.do#!/reference/api/rome/rest/c_TableAPI)
-     * Connectors after the Elastic ServiceNow application use the
-     * Import Set API (https://developer.servicenow.com/dev.do#!/reference/api/rome/rest/c_ImportSetAPI)
-     * A ServiceNow connector is considered deprecated if it uses the Table API.
-     */
-    return !!connector.config.usesTableApi;
-  }
-
-  return false;
+  return connector?.isDeprecated ?? false;
 };