Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Show deprecated icon in connectors with isDeprecated true #132237

Merged
merged 10 commits into from
May 20, 2022
Merged

[Cases] Show deprecated icon in connectors with isDeprecated true #132237

merged 10 commits into from
May 20, 2022

Conversation

academo
Copy link
Contributor

@academo academo commented May 16, 2022 •
edited by cnasikas
Loading

Summary

Changes the logic to mark a connector as deprecated by using the backend "isDeprecated" attribute. This change reflects in all places in cases where a connector can be selected.

Closes: #131033 and #130640

image
image
image

Release note

Show a warning for deprecated preconfigured connectors.

@academo academo self-assigned this May 16, 2022
@academo academo added release_note:fix backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.3.0 labels May 16, 2022
@academo academo requested review from peteharverson and cnasikas May 16, 2022 12:20
@academo academo marked this pull request as ready for review May 16, 2022 12:20
@academo academo requested a review from a team as a code owner May 16, 2022 12:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

peteharverson
peteharverson approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@cnasikas cnasikas force-pushed the fix/deprecated-connector-icon branch from a8e0aa4 to dbeafc2 Compare May 18, 2022 12:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 432 431 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 299.7KB 299.2KB -502.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 81 82 +1

Total ESLint disabled count

id before after diff
cases 97 98 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

@cnasikas cnasikas merged commit 473141f into elastic:main May 20, 2022
@cnasikas cnasikas mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr left review comments

@gmmorris gmmorris gmmorris left review comments

@peteharverson peteharverson peteharverson approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees

@academo academo

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Use the isDeprecated field to check for deprecated connectors.
7 participants
@academo @elasticmachine @kibana-ci @pmuellr @gmmorris @peteharverson @cnasikas