Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] - Add back exceptions export success toast #131952

Merged
merged 4 commits into from
May 12, 2022
+12 −7
Merged

[Security Solution][Exceptions] - Add back exceptions export success toast #131952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e495edf
adding back exceptions export success toast
yctercero May 10, 2022
7b33e02
Merge branch 'main' of github.com:elastic/kibana into exceptions_expo…
yctercero May 10, 2022
c51aa83
remove exclusive suite
yctercero May 10, 2022
98b913a
Merge branch 'main' into exceptions_export_bug
kibanamachine May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions x-pack/plugins/security_solution/cypress/integration/exceptions/exceptions_table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
} from '../../screens/exceptions';
import { createExceptionList } from '../../tasks/api_calls/exceptions';
import { esArchiverResetKibana } from '../../tasks/es_archiver';
import { TOASTER } from '../../screens/alerts_detection_rules';

const getExceptionList1 = () => ({
...getExceptionList(),
Expand Down Expand Up @@ -79,11 +80,14 @@ describe('Exceptions Table', () => {
waitForExceptionsTableToBeLoaded();
exportExceptionList();

cy.wait('@export').then(({ response }) =>
cy
.wrap(response?.body)
.should('eql', expectedExportedExceptionList(this.exceptionListResponse))
);
cy.wait('@export').then(({ response }) => {
cy.wrap(response?.body).should(
'eql',
expectedExportedExceptionList(this.exceptionListResponse)
);

cy.get(TOASTER).should('have.text', 'Exception list export success');
});
});

it('Filters exception lists on search', () => {
Expand Down
5 changes: 3 additions & 2 deletions ...lution/public/detections/pages/detection_engine/rules/all/exceptions/exceptions_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const ExceptionListsTable = React.memo(() => {
const [exportingListIds, setExportingListIds] = useState<string[]>([]);
const [exportDownload, setExportDownload] = useState<{ name?: string; blob?: Blob }>({});
const { navigateToUrl } = application;
const { addError } = useAppToasts();
const { addError, addSuccess } = useAppToasts();

const handleDeleteSuccess = useCallback(
(listId?: string) => () => {
Expand Down Expand Up @@ -165,9 +165,10 @@ export const ExceptionListsTable = React.memo(() => {
const handleExportSuccess = useCallback(
(listId: string) =>
(blob: Blob): void => {
addSuccess(i18n.EXCEPTION_EXPORT_SUCCESS);
setExportDownload({ name: listId, blob });
},
[]
[addSuccess]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@semd Why was this dependency removed in your pr? https://github.com/elastic/kibana/pull/103275/files#diff-23dad27ad5775a9231a0e8ab9d59dd337feae06d763ab45b63767f1101ee6059R168-R172

);

const handleExportError = useCallback(
Expand Down