[Security Solution][Exceptions] - Add back exceptions export success toast #131952
Conversation
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
| setExportDownload({ name: listId, blob }); | ||
| }, | ||
| [] | ||
| [addSuccess] |
There was a problem hiding this comment.
@semd Why was this dependency removed in your pr? https://github.com/elastic/kibana/pull/103275/files#diff-23dad27ad5775a9231a0e8ab9d59dd337feae06d763ab45b63767f1101ee6059R168-R172
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
There was a problem hiding this comment.
LGTM! Disclaimer: I didn't test it but it's simple changes and look correct 👍
I think we should move it outside of x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/exceptions because now it's a dedicated Exception Lists page that deserves its own folder.
@banderror 8.4 is bringing updates to all these exceptions flow and we'll be sure to move it out then! |
…toast (elastic#131952) Addresses elastic#88449 It appears that the success toaster code was deleted at some point as the text for the toaster was already there just not in use. Simple fix to add back in. Added check for toaster to existing cypress test.
Summary
Addresses #88449
It appears that the success toaster code was deleted at some point as the text for the toaster was already there just not in use. Simple fix to add back in. Added check for toaster to existing cypress test.
Checklist