-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove Firefox Tag From Filter Tests #120673
Merged
ThomThomson
merged 2 commits into
elastic:main
from
ThomThomson:unskip/dashboardFilteringFirefox
Dec 9, 2021
Merged
[Dashboard] Remove Firefox Tag From Filter Tests #120673
ThomThomson
merged 2 commits into
elastic:main
from
ThomThomson:unskip/dashboardFilteringFirefox
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… why running with firefox causes failures
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
poffdeluxe
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Dec 9, 2021
… why running with firefox causes failures (elastic#120673)
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
… why running with firefox causes failures (elastic#120673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Dashboard
Dashboard related features
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #120195
Closes #120568
Closes #120195
Related to / follow up to 76857ec
There have been a few issues lately relating to the re-enabling of the dashboard filtering tests in #117944.
All of these new failures only happen when testing with Firefox. I will look into what is causing firefox to be unable to find some filter bar elements, but in the meantime, simply disabling firefox on that suite should stop the flakiness.