Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] [Functional Tests] Unskip Filtering Tests #117944

Merged
merged 8 commits into from
Nov 11, 2021

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Nov 8, 2021

Summary

Fixes #92522

Since the vega issue was fixed, it seemed like a good time to unskip the dashboard filtering tests.

The legacy coordinate map has been removed from the test because it is deprecated and was causing a failure.

The TSVB charts have had their configuration changed slightly in order to load properly.

@elastic/ml-ui Since the dashboard waitForRenderComplete has been fixed to look for the proper number of panels, its usage has been replaced with header.waitUntilLoadingHasFinished in one ML test. This is because waitForRenderComplete requires data and this ML test is running on a time range which shows no data.

Flaky test runner with 100 successful runs!

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 276.4KB 276.5KB +52.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review November 11, 2021 20:01
@ThomThomson ThomThomson requested review from a team as code owners November 11, 2021 20:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@qn895
Copy link
Member

qn895 commented Nov 11, 2021

ML changes LGTM 🎉

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ThomThomson ThomThomson merged commit 44477a4 into elastic:main Nov 11, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Nov 11, 2021
ThomThomson added a commit that referenced this pull request Nov 11, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 v8.1.0
Projects
None yet
5 participants