-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] [Functional Tests] Unskip Filtering Tests #117944
Merged
ThomThomson
merged 8 commits into
elastic:main
from
ThomThomson:unskip/dashboardFiltering
Nov 11, 2021
Merged
[Dashboard] [Functional Tests] Unskip Filtering Tests #117944
ThomThomson
merged 8 commits into
elastic:main
from
ThomThomson:unskip/dashboardFiltering
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-presentation (Team:Presentation) |
ML changes LGTM 🎉 |
qn895
approved these changes
Nov 11, 2021
crob611
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Nov 11, 2021
Unskip dashboard filtering tests
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
Unskip dashboard filtering tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Dashboard
Dashboard related features
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:medium
Medium Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #92522
Since the vega issue was fixed, it seemed like a good time to unskip the dashboard filtering tests.
The legacy coordinate map has been removed from the test because it is deprecated and was causing a failure.
The TSVB charts have had their configuration changed slightly in order to load properly.
@elastic/ml-ui Since the dashboard
waitForRenderComplete
has been fixed to look for the proper number of panels, its usage has been replaced withheader.waitUntilLoadingHasFinished
in one ML test. This is becausewaitForRenderComplete
requires data and this ML test is running on a time range which shows no data.Flaky test runner with 100 successful runs!
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers