Tech debt/substitute legacy request #119888
Conversation
| private authHeadersCache = new WeakMap<LegacyRequest, AuthHeaders>(); | ||
| public set = (request: KibanaRequest | LegacyRequest, headers: AuthHeaders) => { | ||
| private authHeadersCache = new WeakMap<Request, AuthHeaders>(); | ||
| public set = (request: KibanaRequest | Request, headers: AuthHeaders) => { |
There was a problem hiding this comment.
| public set = (request: KibanaRequest | Request, headers: AuthHeaders) => { | |
| public set = (request: KibanaRequest, headers: AuthHeaders) => { |
There was a problem hiding this comment.
I misunderstood the suggestion for replacing LegacyRequest with Hapi.Request as removing the type alias. Thanks for clarifying!
| constructor(private readonly canBeAuthenticated: () => boolean) {} | ||
| public set = (request: KibanaRequest | LegacyRequest, state: unknown) => { | ||
| public set = (request: KibanaRequest | Request, state: unknown) => { |
There was a problem hiding this comment.
| public set = (request: KibanaRequest | Request, state: unknown) => { | |
| public set = (request: KibanaRequest, state: unknown) => { |
There was a problem hiding this comment.
We still need to allow Hapi.Request as the request param type for configuring the auth scheme. Since this is private and internal to Core during the server setup/start, I think it's 'safe' enough to allow a Hapi.Request as well.
If we did want to revisit that, we'd need to do some more refactoring and confirm that changes would be ok with unauthorized Kibana access and other auth work-flows.
| this.storage.set(ensureRawRequest(request), state); | ||
| }; | ||
| public get = <T = unknown>(request: KibanaRequest | LegacyRequest) => { | ||
| public get = <T = unknown>(request: KibanaRequest | Request) => { |
There was a problem hiding this comment.
| public get = <T = unknown>(request: KibanaRequest | Request) => { | |
| public get = <T = unknown>(request: KibanaRequest) => { |
dfe45e0 to
1a6eccb
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failedThe backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
Resolves #119867
This PR handles the remaining usages of
LegacyRequestin core http by substitutingLegacyRequestwithHapi.Requestand removes the type from thehttpinterface.Checklist
Delete any items that are not applicable to this PR.
For maintainers