Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup usage of LegacyRequest #119867

Closed
TinaHeiligers opened this issue Nov 29, 2021 · 1 comment · Fixed by #119888
Closed

Cleanup usage of LegacyRequest #119867

TinaHeiligers opened this issue Nov 29, 2021 · 1 comment · Fixed by #119888
Assignees
@TinaHeiligers
Labels
chore Feature:Legacy Removal Issues related to removing legacy Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Nov 29, 2021 •
edited
Loading

In #77997, we found that core still uses LegacyRequest in a few places that wasn't handled in #109243.

Similarly, core still uses LegacyRequest in:

  1. ensureRawRequest
  2. AuthHeadersStorage
  3. AuthStateStorage
  4. BasePath

We need to reference Hapi.Request in the codebase. Probably we should remove substitute LegacyRequest type with Hapi.Request to remove this ambiguity.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 29, 2021
@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed needs-team Issues missing a team label labels Nov 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers added chore Feature:Legacy Removal Issues related to removing legacy Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture labels Nov 29, 2021
@TinaHeiligers TinaHeiligers self-assigned this Nov 29, 2021
@TinaHeiligers TinaHeiligers mentioned this issue Nov 29, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
chore Feature:Legacy Removal Issues related to removing legacy Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tech debt/substitute legacy request TinaHeiligers/kibana
2 participants
@TinaHeiligers @elasticmachine