Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Replace EUICodeEditor with Monaco #116041

Merged
merged 9 commits into from
Nov 11, 2021
Merged

[Vega] Replace EUICodeEditor with Monaco #116041

merged 9 commits into from
Nov 11, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 22, 2021 •
edited
Loading

Closes: #106967

Summary

This PR replaces the deprecated EUICodeEditor in favor of the Monaco (CodeEditor component) for Vega.

What was done:

  • new lexical language for hjson was created
  • code editor was replaced for Vega Editor
  • tests were updated

Screens

Before:

image

After:

image

@alexwizp alexwizp force-pushed the 106967 branch 3 times, most recently from 7752bd0 to 0b7b5b4 Compare October 25, 2021 13:25
@alexwizp alexwizp self-assigned this Oct 26, 2021
@alexwizp alexwizp added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:enhancement labels Oct 26, 2021
@alexwizp alexwizp marked this pull request as ready for review October 26, 2021 12:17
@alexwizp alexwizp requested review from a team as code owners October 26, 2021 12:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elastic/kibana-vis-editors / @elastic/kibana-presentation please have a look

@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 1, 2021

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 3, 2021

@elasticmachine merge upstream

@alexwizp alexwizp added the v8.1.0 label Nov 3, 2021
@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 5, 2021

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 8, 2021

@elasticmachine merge upstream

@stratoula stratoula removed the v8.0.0 label Nov 8, 2021
stratoula
stratoula approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I tested it locally and works fine! I removed the v8.0 as it is after the FF and is an enhancement.

@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 9, 2021

@elastic/kibana-presentation could you please have a look?

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaReact 298 301 +3
visTypeVega 225 226 +1
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 204 205 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 206.7KB 208.2KB +1.5KB
visTypeVega 1.9MB 1.9MB -7.1KB
total -5.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 57.2KB 57.4KB +135.0B
visTypeVega 37.2KB 37.1KB -91.0B
total +44.0B
Unknown metric groups

API count

id before after diff
kibanaReact 228 229 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

crob611
crob611 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good for me 👍

@alexwizp alexwizp added the backport:skip This commit does not require backporting label Nov 11, 2021
@alexwizp alexwizp merged commit 58b39bc into elastic:main Nov 11, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@alexwizp @kibanamachine @dmlemeshko
[Vega] Replace EUICodeEditor with Monaco (#116041)
266b842 
Closes: #106967

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@crob611 crob611 crob611 approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Vega Vega visualizations release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vega] Replace EUICodeEditor with Monaco
6 participants
@alexwizp @elasticmachine @kibanamachine @ryankeairns @crob611 @stratoula