Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Replace EUICodeEditor with Monaco #106967

Closed
stratoula opened this issue Jul 28, 2021 · 1 comment · Fixed by #116041
Closed

[Vega] Replace EUICodeEditor with Monaco #106967

stratoula opened this issue Jul 28, 2021 · 1 comment · Fixed by #116041
Assignees
@alexwizp
Labels
Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

The EUI Code editor is deprecated so we want to replace it with Monaco on our vega spec.

  • It should give the same capabilities to the user as the old editor
  • The tests should be updated

Part of #106931
@stratoula stratoula added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Aug 2, 2021
Closed
19 tasks
@alexwizp alexwizp self-assigned this Oct 20, 2021
@alexwizp alexwizp mentioned this issue Oct 22, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 26, 2021
@alexwizp
[Vega] Replace EUICodeEditor with Monaco
e7ef44a 
Closes: elastic#106967
@flash1293 flash1293 mentioned this issue Oct 27, 2021
Closed
alexwizp added a commit that referenced this issue Nov 11, 2021
@alexwizp @kibanamachine
[Vega] Replace EUICodeEditor with Monaco (#116041)
58b39bc 
Closes: #106967

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this issue Nov 29, 2021
@alexwizp @kibanamachine @dmlemeshko
[Vega] Replace EUICodeEditor with Monaco (#116041)
266b842 
Closes: #106967

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@Karql Karql mentioned this issue Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Vega] Replace EUICodeEditor with Monaco alexwizp/kibana
3 participants
@elasticmachine @stratoula @alexwizp