Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] migrate elasticsearch node overview page to React #113318

Merged
merged 2 commits into from
Sep 29, 2021
Merged

[Stack Monitoring] migrate elasticsearch node overview page to React #113318

merged 2 commits into from
Sep 29, 2021

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Sep 28, 2021 •
edited
Loading

#113339
#112822

Migrates Elasticsearch -> Nodes -> Overview page

  • Breadcrumbs will not be correct as its being done separately
  • The tab menu is not correct and I will implement it when migrating the Nodes -> Advanced view . In this PR it continues to use the Nodes view menu. This is what it will look like after updated:
    Screen Shot 2021-09-28 at 1 43 08 PM
  • Instead of using the existing React components which have angular functionality embedded in them i created new components of the same name appended with "React" which can be removed when "Angular mode" is no longer needed.

Test

  • Access the page by going to Elasticsearch Nodes listing. Click on one of the nodes (pick one with shards):

Screen Shot 2021-09-28 at 6 36 22 PM

  • Make sure the page updates with new data when it auto refreshes (I used Edge to get some data)
  • Clicking on "Filter for system indices" under Shard Legend to hide or show system indices should work update correctly
  • make sure you can drag and zoom into the charts

@neptunian neptunian self-assigned this Sep 28, 2021
neptunian
neptunian commented Sep 28, 2021
View reviewed changes
x-pack/plugins/monitoring/public/application/hooks/use_local_storage.ts
interface ParsedMonitoringData {
[key: string]: any;
}
export const useLocalStorage = <Value>(key: string, defaultValue: Value): [Value, Function] => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hook replaces the "features" service https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/services/features.js

@neptunian neptunian marked this pull request as ready for review September 28, 2021 20:14
@neptunian neptunian requested a review from a team as a code owner September 28, 2021 20:14
@neptunian neptunian requested review from a team September 28, 2021 20:14
This was referenced Sep 28, 2021
Closed
Closed
@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

matschaffer
matschaffer approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me on docker-test-cluster. It has the same brush/url update issue I've seen on other graphs, but #112063 should address that.

@neptunian neptunian added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Stack Monitoring labels Sep 29, 2021
@neptunian neptunian merged commit 682a1c1 into elastic:master Sep 29, 2021
@neptunian neptunian mentioned this pull request Sep 29, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@neptunian @kibanamachine
node view (elastic#113318)
316be89 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 29, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

neptunian added a commit to neptunian/kibana that referenced this pull request Sep 29, 2021
@neptunian @kibanamachine
node view (elastic#113318)
322b1c5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 607 614 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 953.1KB 972.3KB +19.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

neptunian added a commit that referenced this pull request Sep 29, 2021
@neptunian @kibanamachine
node view (#113318) (#113401)
ffa8f8e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@neptunian neptunian mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees

@neptunian neptunian

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neptunian @kibanamachine @matschaffer