Merge branch 'master' into 112822-node-view

elastic · Sep 28, 2021 · e7a6811 · e7a6811
2 parents dbbe883 + bd699ac
commit e7a6811
Show file tree

Hide file tree

Showing 75 changed files with 206 additions and 246 deletions.
diff --git a/docs/migration/migrate_8_0.asciidoc b/docs/migration/migrate_8_0.asciidoc
@@ -259,6 +259,12 @@ URL that it derived from the actual server address and `xpack.security.public` s
 
 *Impact:* Any workflow that involved manually clearing generated bundles will have to be updated with the new path.
 
+[float]
+=== Legacy `optimize.*` settings are no longer supported
+*Details:*  The legacy optimizer has been removed and any `optimize.*` settings have been deprecated since 7.10. These settings have been removed as they are no longer in use.
+
+*Impact:* Any of the legacy `optimize.*` settings will prevent Kibana from starting up. Going forward, to run the `@kbn/optimizer` separately in development, pass `--no-optimizer` to `yarn start`. See https://github.com/elastic/kibana/pull/73154 for more details.
+
 [float]
 === kibana.keystore has moved from the `data` folder to the `config` folder
 *Details:* By default, kibana.keystore has moved from the configured `path.data` folder to `<root>/config` for archive distributions

diff --git a/rfcs/0000_template.md → legacy_rfcs/0000_template.md b/rfcs/0000_template.md → legacy_rfcs/0000_template.md
diff --git a/legacy_rfcs/README.md b/legacy_rfcs/README.md
@@ -0,0 +1,3 @@
+# Kibana RFCs
+
+We no longer follow this RFC process. Internal developers should review the new RFC process in our [internal developer guide](https://docs.elastic.dev/kibana-team/rfc-process)
diff --git a/rfcs/images/0018_agent_manager.png → legacy_rfcs/images/0018_agent_manager.png b/rfcs/images/0018_agent_manager.png → legacy_rfcs/images/0018_agent_manager.png
diff --git a/rfcs/images/0018_buildkite_build.png → legacy_rfcs/images/0018_buildkite_build.png b/rfcs/images/0018_buildkite_build.png → legacy_rfcs/images/0018_buildkite_build.png
diff --git a/rfcs/images/0018_buildkite_deps.png → legacy_rfcs/images/0018_buildkite_deps.png b/rfcs/images/0018_buildkite_deps.png → legacy_rfcs/images/0018_buildkite_deps.png
diff --git a/rfcs/images/0018_buildkite_uptime.png → legacy_rfcs/images/0018_buildkite_uptime.png b/rfcs/images/0018_buildkite_uptime.png → legacy_rfcs/images/0018_buildkite_uptime.png
diff --git a/rfcs/images/0018_jenkins_pipeline_steps.png → ...cs/images/0018_jenkins_pipeline_steps.png b/rfcs/images/0018_jenkins_pipeline_steps.png → ...cs/images/0018_jenkins_pipeline_steps.png
diff --git a/rfcs/images/0019_lifecycle_preboot.png → ...cy_rfcs/images/0019_lifecycle_preboot.png b/rfcs/images/0019_lifecycle_preboot.png → ...cy_rfcs/images/0019_lifecycle_preboot.png
diff --git a/rfcs/images/20_clustering/cluster_mode.png → ...fcs/images/20_clustering/cluster_mode.png b/rfcs/images/20_clustering/cluster_mode.png → ...fcs/images/20_clustering/cluster_mode.png
diff --git a/.../images/20_clustering/no_cluster_mode.png → .../images/20_clustering/no_cluster_mode.png b/.../images/20_clustering/no_cluster_mode.png → .../images/20_clustering/no_cluster_mode.png
diff --git a/rfcs/images/20_clustering/perf_4_workers.png → ...s/images/20_clustering/perf_4_workers.png b/rfcs/images/20_clustering/perf_4_workers.png → ...s/images/20_clustering/perf_4_workers.png
diff --git a/...0_clustering/perf_clustering_2_worker.png → ...0_clustering/perf_clustering_2_worker.png b/...0_clustering/perf_clustering_2_worker.png → ...0_clustering/perf_clustering_2_worker.png
diff --git a/...ages/20_clustering/perf_no_clustering.png → ...ages/20_clustering/perf_no_clustering.png b/...ages/20_clustering/perf_no_clustering.png → ...ages/20_clustering/perf_no_clustering.png
diff --git a/rfcs/images/api_doc_pick.png → legacy_rfcs/images/api_doc_pick.png b/rfcs/images/api_doc_pick.png → legacy_rfcs/images/api_doc_pick.png
diff --git a/rfcs/images/api_doc_tech.png → legacy_rfcs/images/api_doc_tech.png b/rfcs/images/api_doc_tech.png → legacy_rfcs/images/api_doc_tech.png
diff --git a/rfcs/images/api_doc_tech_compare.png → legacy_rfcs/images/api_doc_tech_compare.png b/rfcs/images/api_doc_tech_compare.png → legacy_rfcs/images/api_doc_tech_compare.png
diff --git a/rfcs/images/api_docs.png → legacy_rfcs/images/api_docs.png b/rfcs/images/api_docs.png → legacy_rfcs/images/api_docs.png
diff --git a/rfcs/images/api_docs_package_current.png → ..._rfcs/images/api_docs_package_current.png b/rfcs/images/api_docs_package_current.png → ..._rfcs/images/api_docs_package_current.png
diff --git a/rfcs/images/api_info.png → legacy_rfcs/images/api_info.png b/rfcs/images/api_info.png → legacy_rfcs/images/api_info.png
diff --git a/rfcs/images/current_api_doc_links.png → legacy_rfcs/images/current_api_doc_links.png b/rfcs/images/current_api_doc_links.png → legacy_rfcs/images/current_api_doc_links.png
diff --git a/rfcs/images/new_api_docs_with_links.png → ...y_rfcs/images/new_api_docs_with_links.png b/rfcs/images/new_api_docs_with_links.png → ...y_rfcs/images/new_api_docs_with_links.png
diff --git a/rfcs/images/ols_phase_1_auth.png → legacy_rfcs/images/ols_phase_1_auth.png b/rfcs/images/ols_phase_1_auth.png → legacy_rfcs/images/ols_phase_1_auth.png
diff --git a/rfcs/images/pulse_diagram.png → legacy_rfcs/images/pulse_diagram.png b/rfcs/images/pulse_diagram.png → legacy_rfcs/images/pulse_diagram.png
diff --git a/rfcs/images/repeat_primitive_signature.png → ...fcs/images/repeat_primitive_signature.png b/rfcs/images/repeat_primitive_signature.png → ...fcs/images/repeat_primitive_signature.png
diff --git a/rfcs/images/repeat_type_links.png → legacy_rfcs/images/repeat_type_links.png b/rfcs/images/repeat_type_links.png → legacy_rfcs/images/repeat_type_links.png
diff --git a/rfcs/images/search_sessions_client.png → ...cy_rfcs/images/search_sessions_client.png b/rfcs/images/search_sessions_client.png → ...cy_rfcs/images/search_sessions_client.png
diff --git a/rfcs/images/search_sessions_server.png → ...cy_rfcs/images/search_sessions_server.png b/rfcs/images/search_sessions_server.png → ...cy_rfcs/images/search_sessions_server.png
diff --git a/rfcs/images/timeslider/toolbar.png → legacy_rfcs/images/timeslider/toolbar.png b/rfcs/images/timeslider/toolbar.png → legacy_rfcs/images/timeslider/toolbar.png
diff --git a/rfcs/images/timeslider/v1.png → legacy_rfcs/images/timeslider/v1.png b/rfcs/images/timeslider/v1.png → legacy_rfcs/images/timeslider/v1.png
diff --git a/rfcs/images/timeslider/v2.png → legacy_rfcs/images/timeslider/v2.png b/rfcs/images/timeslider/v2.png → legacy_rfcs/images/timeslider/v2.png
diff --git a/rfcs/images/url_service/new_architecture.png → ...s/images/url_service/new_architecture.png b/rfcs/images/url_service/new_architecture.png → ...s/images/url_service/new_architecture.png
diff --git a/rfcs/images/url_service/old_architecture.png → ...s/images/url_service/old_architecture.png b/rfcs/images/url_service/old_architecture.png → ...s/images/url_service/old_architecture.png
diff --git a/rfcs/text/.gitkeep → legacy_rfcs/text/.gitkeep b/rfcs/text/.gitkeep → legacy_rfcs/text/.gitkeep
diff --git a/rfcs/text/0001_lifecycle_setup.md → legacy_rfcs/text/0001_lifecycle_setup.md b/rfcs/text/0001_lifecycle_setup.md → legacy_rfcs/text/0001_lifecycle_setup.md
diff --git a/rfcs/text/0002_encrypted_attributes.md → ...cy_rfcs/text/0002_encrypted_attributes.md b/rfcs/text/0002_encrypted_attributes.md → ...cy_rfcs/text/0002_encrypted_attributes.md
diff --git a/rfcs/text/0003_handler_interface.md → legacy_rfcs/text/0003_handler_interface.md b/rfcs/text/0003_handler_interface.md → legacy_rfcs/text/0003_handler_interface.md
diff --git a/...text/0004_application_service_mounting.md → ...text/0004_application_service_mounting.md b/...text/0004_application_service_mounting.md → ...text/0004_application_service_mounting.md
diff --git a/rfcs/text/0005_route_handler.md → legacy_rfcs/text/0005_route_handler.md b/rfcs/text/0005_route_handler.md → legacy_rfcs/text/0005_route_handler.md
diff --git a/rfcs/text/0006_management_section_service.md → ...s/text/0006_management_section_service.md b/rfcs/text/0006_management_section_service.md → ...s/text/0006_management_section_service.md
diff --git a/rfcs/text/0007_lifecycle_unblocked.md → legacy_rfcs/text/0007_lifecycle_unblocked.md b/rfcs/text/0007_lifecycle_unblocked.md → legacy_rfcs/text/0007_lifecycle_unblocked.md
diff --git a/rfcs/text/0008_pulse.md → legacy_rfcs/text/0008_pulse.md b/rfcs/text/0008_pulse.md → legacy_rfcs/text/0008_pulse.md
diff --git a/rfcs/text/0009_screenshot_mode_service.md → ...rfcs/text/0009_screenshot_mode_service.md b/rfcs/text/0009_screenshot_mode_service.md → ...rfcs/text/0009_screenshot_mode_service.md
diff --git a/rfcs/text/0010_service_status.md → legacy_rfcs/text/0010_service_status.md b/rfcs/text/0010_service_status.md → legacy_rfcs/text/0010_service_status.md
diff --git a/rfcs/text/0011_global_search.md → legacy_rfcs/text/0011_global_search.md b/rfcs/text/0011_global_search.md → legacy_rfcs/text/0011_global_search.md
diff --git a/rfcs/text/0011_reporting_as_an_api.md → legacy_rfcs/text/0011_reporting_as_an_api.md b/rfcs/text/0011_reporting_as_an_api.md → legacy_rfcs/text/0011_reporting_as_an_api.md
diff --git a/rfcs/text/0012_encryption_key_rotation.md → ...rfcs/text/0012_encryption_key_rotation.md b/rfcs/text/0012_encryption_key_rotation.md → ...rfcs/text/0012_encryption_key_rotation.md
diff --git a/rfcs/text/0013_saved_object_migrations.md → ...rfcs/text/0013_saved_object_migrations.md b/rfcs/text/0013_saved_object_migrations.md → ...rfcs/text/0013_saved_object_migrations.md
diff --git a/rfcs/text/0013_search_sessions.md → legacy_rfcs/text/0013_search_sessions.md b/rfcs/text/0013_search_sessions.md → legacy_rfcs/text/0013_search_sessions.md
diff --git a/rfcs/text/0014_api_documentation.md → legacy_rfcs/text/0014_api_documentation.md b/rfcs/text/0014_api_documentation.md → legacy_rfcs/text/0014_api_documentation.md
diff --git a/rfcs/text/0015_bazel.md → legacy_rfcs/text/0015_bazel.md b/rfcs/text/0015_bazel.md → legacy_rfcs/text/0015_bazel.md
diff --git a/rfcs/text/0016_ols_phase_1.md → legacy_rfcs/text/0016_ols_phase_1.md b/rfcs/text/0016_ols_phase_1.md → legacy_rfcs/text/0016_ols_phase_1.md
diff --git a/rfcs/text/0017_url_service.md → legacy_rfcs/text/0017_url_service.md b/rfcs/text/0017_url_service.md → legacy_rfcs/text/0017_url_service.md
diff --git a/rfcs/text/0018_buildkite.md → legacy_rfcs/text/0018_buildkite.md b/rfcs/text/0018_buildkite.md → legacy_rfcs/text/0018_buildkite.md
diff --git a/rfcs/text/0018_timeslider.md → legacy_rfcs/text/0018_timeslider.md b/rfcs/text/0018_timeslider.md → legacy_rfcs/text/0018_timeslider.md
diff --git a/rfcs/text/0019_lifecycle_preboot.md → legacy_rfcs/text/0019_lifecycle_preboot.md b/rfcs/text/0019_lifecycle_preboot.md → legacy_rfcs/text/0019_lifecycle_preboot.md
diff --git a/rfcs/text/0020_nodejs_clustering.md → legacy_rfcs/text/0020_nodejs_clustering.md b/rfcs/text/0020_nodejs_clustering.md → legacy_rfcs/text/0020_nodejs_clustering.md
diff --git a/rfcs/README.md b/rfcs/README.md
diff --git a/src/core/server/config/deprecation/core_deprecations.ts b/src/core/server/config/deprecation/core_deprecations.ts
@@ -353,25 +353,6 @@ const logFilterDeprecation: ConfigDeprecation = (settings, fromPath, addDeprecat
 };
 
 export const coreDeprecationProvider: ConfigDeprecationProvider = ({ rename, unusedFromRoot }) => [
-  unusedFromRoot('optimize.lazy'),
-  unusedFromRoot('optimize.lazyPort'),
-  unusedFromRoot('optimize.lazyHost'),
-  unusedFromRoot('optimize.lazyPrebuild'),
-  unusedFromRoot('optimize.lazyProxyTimeout'),
-  unusedFromRoot('optimize.enabled'),
-  unusedFromRoot('optimize.bundleFilter'),
-  unusedFromRoot('optimize.bundleDir'),
-  unusedFromRoot('optimize.viewCaching'),
-  unusedFromRoot('optimize.watch'),
-  unusedFromRoot('optimize.watchPort'),
-  unusedFromRoot('optimize.watchHost'),
-  unusedFromRoot('optimize.watchPrebuild'),
-  unusedFromRoot('optimize.watchProxyTimeout'),
-  unusedFromRoot('optimize.useBundleCache'),
-  unusedFromRoot('optimize.sourceMaps'),
-  unusedFromRoot('optimize.workers'),
-  unusedFromRoot('optimize.profile'),
-  unusedFromRoot('optimize.validateSyntaxOfNodeModules'),
   rename('cpu.cgroup.path.override', 'ops.cGroupOverrides.cpuPath'),
   rename('cpuacct.cgroup.path.override', 'ops.cGroupOverrides.cpuAcctPath'),
   rename('server.xsrf.whitelist', 'server.xsrf.allowlist'),

diff --git a/src/core/server/config/integration_tests/config_deprecation.test.ts b/src/core/server/config/integration_tests/config_deprecation.test.ts
@@ -36,25 +36,4 @@ describe('configuration deprecations', () => {
       ]
     `);
   });
-
-  it('should log deprecation warnings for core deprecations', async () => {
-    root = kbnTestServer.createRoot({
-      optimize: {
-        lazy: true,
-        lazyPort: 9090,
-      },
-    });
-
-    await root.preboot();
-    await root.setup();
-
-    const logs = loggingSystemMock.collect(mockLoggingSystem);
-    expect(logs.warn.flat()).toMatchInlineSnapshot(`
-      Array [
-        "You no longer need to configure \\"optimize.lazy\\".",
-        "You no longer need to configure \\"optimize.lazyPort\\".",
-        "\\"logging.silent\\" has been deprecated and will be removed in 8.0. Moving forward, you can use \\"logging.root.level:off\\" in your logging configuration. ",
-      ]
-    `);
-  });
 });
diff --git a/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.ts b/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.ts
@@ -38,6 +38,7 @@ import {
   syncDashboardUrlState,
   diffDashboardState,
   areTimeRangesEqual,
+  areRefreshIntervalsEqual,
 } from '../lib';
 
 export interface UseDashboardStateProps {
@@ -241,13 +242,17 @@ export const useDashboardAppState = ({
 
           const savedTimeChanged =
             lastSaved.timeRestore &&
-            !areTimeRangesEqual(
+            (!areTimeRangesEqual(
               {
                 from: savedDashboard?.timeFrom,
                 to: savedDashboard?.timeTo,
               },
               timefilter.getTime()
-            );
+            ) ||
+              !areRefreshIntervalsEqual(
+                savedDashboard?.refreshInterval,
+                timefilter.getRefreshInterval()
+              ));
 
           /**
            * changes to the dashboard should only be considered 'unsaved changes' when

diff --git a/src/plugins/dashboard/public/application/lib/filter_utils.ts b/src/plugins/dashboard/public/application/lib/filter_utils.ts
@@ -10,9 +10,10 @@ import _ from 'lodash';
 import moment, { Moment } from 'moment';
 import { Optional } from '@kbn/utility-types';
 
-import { Filter, TimeRange } from '../../services/data';
+import { Filter, TimeRange, RefreshInterval } from '../../services/data';
 
 type TimeRangeCompare = Optional<TimeRange>;
+type RefreshIntervalCompare = Optional<RefreshInterval>;
 
 /**
  * Converts the time to a utc formatted string. If the time is not valid (e.g. it might be in a relative format like
@@ -31,9 +32,13 @@ export const convertTimeToUTCString = (time?: string | Moment): undefined | stri
   }
 };
 
-export const areTimeRangesEqual = (rangeA: TimeRangeCompare, rangeB: TimeRangeCompare): boolean => {
-  return areTimesEqual(rangeA.from, rangeB.from) && areTimesEqual(rangeA.to, rangeB.to);
-};
+export const areTimeRangesEqual = (rangeA: TimeRangeCompare, rangeB: TimeRangeCompare): boolean =>
+  areTimesEqual(rangeA.from, rangeB.from) && areTimesEqual(rangeA.to, rangeB.to);
+
+export const areRefreshIntervalsEqual = (
+  refreshA?: RefreshIntervalCompare,
+  refreshB?: RefreshIntervalCompare
+): boolean => refreshA?.pause === refreshB?.pause && refreshA?.value === refreshB?.value;
 
 /**
  * Compares the two times, making sure they are in both compared in string format. Absolute times

diff --git a/test/accessibility/apps/dashboard.ts b/test/accessibility/apps/dashboard.ts
@@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
   const listingTable = getService('listingTable');
 
-  describe.skip('Dashboard', () => {
+  describe('Dashboard', () => {
     const dashboardName = 'Dashboard Listing A11y';
     const clonedDashboardName = 'Dashboard Listing A11y Copy';
 

diff --git a/test/accessibility/config.ts b/test/accessibility/config.ts
@@ -17,15 +17,19 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
     ...functionalConfig.getAll(),
 
     testFiles: [
-      require.resolve('./apps/discover'),
+      // these 5 tests all load addSampleDataSet('flights')
+      // only the last test does removeSampleDataSet('flights')
       require.resolve('./apps/dashboard'),
       require.resolve('./apps/dashboard_panel'),
+      require.resolve('./apps/filter_panel'),
+      require.resolve('./apps/home'),
+      require.resolve('./apps/kibana_overview'),
+
+      // next tests don't use sample data
+      require.resolve('./apps/discover'),
       require.resolve('./apps/visualize'),
       require.resolve('./apps/management'),
       require.resolve('./apps/console'),
-      require.resolve('./apps/home'),
-      require.resolve('./apps/filter_panel'),
-      require.resolve('./apps/kibana_overview'),
     ],
     pageObjects,
     services,

diff --git a/test/functional/page_objects/home_page.ts b/test/functional/page_objects/home_page.ts
@@ -45,8 +45,11 @@ export class HomePageObject extends FtrService {
   async addSampleDataSet(id: string) {
     const isInstalled = await this.isSampleDataSetInstalled(id);
     if (!isInstalled) {
-      await this.testSubjects.click(`addSampleDataSet${id}`);
-      await this._waitForSampleDataLoadingAction(id);
+      await this.retry.waitFor('wait until sample data is installed', async () => {
+        await this.testSubjects.click(`addSampleDataSet${id}`);
+        await this._waitForSampleDataLoadingAction(id);
+        return await this.isSampleDataSetInstalled(id);
+      });
     }
   }
 

diff --git a/...ns/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/header_filters.spec.ts b/...ns/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/header_filters.spec.ts
@@ -16,43 +16,43 @@ const serviceOverviewHref = url.format({
 
 const apisToIntercept = [
   {
-    endpoint: '/api/apm/services/opbeans-node/transactions/charts/latency',
+    endpoint: '/api/apm/services/opbeans-node/transactions/charts/latency?*',
     name: 'latencyChartRequest',
   },
   {
-    endpoint: '/api/apm/services/opbeans-node/throughput',
+    endpoint: '/api/apm/services/opbeans-node/throughput?*',
     name: 'throughputChartRequest',
   },
   {
-    endpoint: '/api/apm/services/opbeans-node/transactions/charts/error_rate',
+    endpoint: '/api/apm/services/opbeans-node/transactions/charts/error_rate?*',
     name: 'errorRateChartRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-node/transactions/groups/detailed_statistics',
+      '/api/apm/services/opbeans-node/transactions/groups/detailed_statistics?*',
     name: 'transactionGroupsDetailedRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-node/service_overview_instances/detailed_statistics',
+      '/api/apm/services/opbeans-node/service_overview_instances/detailed_statistics?*',
     name: 'instancesDetailedRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-node/service_overview_instances/main_statistics',
+      '/api/apm/services/opbeans-node/service_overview_instances/main_statistics?*',
     name: 'instancesMainStatisticsRequest',
   },
   {
-    endpoint: '/api/apm/services/opbeans-node/error_groups/main_statistics',
+    endpoint: '/api/apm/services/opbeans-node/error_groups/main_statistics?*',
     name: 'errorGroupsMainStatisticsRequest',
   },
   {
-    endpoint: '/api/apm/services/opbeans-node/transaction/charts/breakdown',
+    endpoint: '/api/apm/services/opbeans-node/transaction/charts/breakdown?*',
     name: 'transactonBreakdownRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-node/transactions/groups/main_statistics',
+      '/api/apm/services/opbeans-node/transactions/groups/main_statistics?*',
     name: 'transactionsGroupsMainStatisticsRequest',
   },
 ];

diff --git a/...s/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/instances_table.spec.ts b/...s/apm/ftr_e2e/cypress/integration/read_only_user/service_overview/instances_table.spec.ts
@@ -18,22 +18,17 @@ const serviceOverviewHref = url.format({
 const apisToIntercept = [
   {
     endpoint:
-      '/api/apm/services/opbeans-java/service_overview_instances/main_statistics',
+      '/api/apm/services/opbeans-java/service_overview_instances/main_statistics?*',
     name: 'instancesMainRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-java/service_overview_instances/detailed_statistics',
+      '/api/apm/services/opbeans-java/service_overview_instances/detailed_statistics?*',
     name: 'instancesDetailsRequest',
   },
   {
     endpoint:
-      '/api/apm/services/opbeans-java/service_overview_instances/details/31651f3c624b81c55dd4633df0b5b9f9ab06b151121b0404ae796632cd1f87ad',
-    name: 'instanceDetailsRequest',
-  },
-  {
-    endpoint:
-      '/api/apm/services/opbeans-java/service_overview_instances/details/31651f3c624b81c55dd4633df0b5b9f9ab06b151121b0404ae796632cd1f87ad',
+      '/api/apm/services/opbeans-java/service_overview_instances/details/31651f3c624b81c55dd4633df0b5b9f9ab06b151121b0404ae796632cd1f87ad?*',
     name: 'instanceDetailsRequest',
   },
 ];
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		# Kibana RFCs

		We no longer follow this RFC process. Internal developers should review the new RFC process in our [internal developer guide](https://docs.elastic.dev/kibana-team/rfc-process)