Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SavedObjectType.management.displayName #113091

Merged
merged 7 commits into from
Sep 28, 2021
Merged

add SavedObjectType.management.displayName #113091

merged 7 commits into from
Sep 28, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Sep 27, 2021 •
edited
Loading

Summary

Fix #105575

Introduce a new management.displayName option when registering a SO type to allow type owners to specify the label used for the type in SO management.

(Note: dashboard only has a displayName for testing and screenshot purposes)

Screenshot 2021-09-27 at 15 06 07

Screenshot 2021-09-27 at 15 06 21

Screenshot 2021-09-27 at 15 06 32

Checklist

@pgayvallet pgayvallet added Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
savedObjectsManagement 85 90 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsManagement 84.0KB 84.3KB +238.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjectsManagement 16.6KB 16.6KB -9.0B
Unknown metric groups

API count

id before after diff
core 2292 2293 +1
savedObjectsManagement 98 103 +5
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review September 28, 2021 09:22
@pgayvallet pgayvallet requested a review from a team as a code owner September 28, 2021 09:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet merged commit daaa6f8 into elastic:master Sep 28, 2021
@pgayvallet pgayvallet mentioned this pull request Sep 28, 2021
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Sep 28, 2021
@pgayvallet
add SavedObjectType.management.displayName (elastic#113091)
068a005 
* add `SavedObjectType.management.displayName`

* fix unit tests

* add FTR test

* update generated doc

* also update labels

* fix unit tests
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx
@ymao1 ymao1 mentioned this pull request Sep 28, 2021
Closed
pgayvallet added a commit that referenced this pull request Sep 28, 2021
@pgayvallet
[7.x] add SavedObjectType.management.displayName (#113091) (#113249)
102822f 
* add `SavedObjectType.management.displayName` (#113091)

* add `SavedObjectType.management.displayName`

* fix unit tests

* add FTR test

* update generated doc

* also update labels

* fix unit tests
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

* fix types

* fix allowedTypes usage

* fix unit tests
@ymao1 ymao1 mentioned this pull request Nov 17, 2021
Closed
@pgayvallet pgayvallet mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
Feature:Saved Objects Management release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent terminology in the Saved Objects UX
4 participants
@pgayvallet @kibanamachine @elasticmachine @rudolf