Global search bar - displays 'index pattern' instead of 'data view'

[mattkime]

Two issues - both the display of the item AND the string used to find it type:index-pattern -

...and the docs need to be updated accordingly, depending upon how this is resolved -

>

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[pgayvallet]

We need to use the management.displayName property that was introduced in #113091, instead of type.name

[pgayvallet]

So, fixing the displayed label is quite easy. However regarding the search term, the fact that the displayName of index-pattern has a space in it (data view) makes searching by this type slightly more complicated for the user, as he's forced to escape with double quotes:

However to be honest, I can't really do better without introducing further hacky logic in the result provider. Types are expected to be exact matches, and I quite don't like the idea of changing this. (also note that searching by type:index-pattern would still work, I'm allowing both)

@mattkime does this forced escaping seem acceptable to you?

[pgayvallet]

nm, we're already doing lower-case conversion during the matching, I guess replacing with - is acceptable. User will then be able to search using type:data-view