[Lens][Visualize] Align inspector header in Lens and Visualize #112443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
stratoula
approved these changes
Sep 20, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2021
…ic#112443) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2021
…) (#112558) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112060
This PR aligns the Inspector panel title when shown within both Lens and Visualize editors.
Now the header is showing the visualization title when available and the
Inspectorplaceholder when there's no title yet.Note that when testing in Dashboard the title of the panel is different from the title of the visualization.
Mind #112442 when testing this fix, as it can still affect it.
Checklist
Delete any items that are not applicable to this PR.