Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Lens] Empty title is not preserved when returning to dashboard from editor #112442

Closed
dej611 opened this issue Sep 16, 2021 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dej611
Copy link
Contributor

dej611 commented Sep 16, 2021

Describe the bug:

If the user sets the Lens panel title to an empty string, navigating to the Lens editor and returning back to Dashboard makes the title rollback to its previous non-empty state.
It can be reproduced both by cloning a Lens panel with a title and removing it, or importing a chart from library and editing the title: clicking on the Edit in Lens action and returning back to the dashboard in edit mode makes the previous title return.

When in view mode the title gets hidden, so it's not a major issue I think.

@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated labels Sep 16, 2021
@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 16, 2021
@ThomThomson
Copy link
Contributor

While this small bug still exists, I am going to close this for now.

Setting the title to a blank string technically does work, but is absolutely not the preferred way of hiding a panel's title. If the user turns off the show panel title switch instead of using a blank string, it will persist when navigating to lens and back.

Screen Shot 2021-10-28 at 3 49 36 PM

@ThomThomson ThomThomson self-assigned this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants