-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Show validation feedback on top values out of bounds number of values #110222
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tested it locally and it works fine 😉
Just a comment here, I see that we have two cases of validations in Lens number inputs:
- if the user adds a value outside the predefined thresholds, we display an error message (like in this PR)
- If a user adds a value outside the predefined thresholds, we automatically change them to the accepted threshold. (for example in the legends popover number inputs)
Does it make sense to align the behaviors?
cc @MichaelMarcialis
Excellent question, @stratoula. We absolutely should be aligning behaviors such as this when it makes sense to do so. And I agree with you in believing that this is indeed one of those situations. For a tool like Lens, where configuration changes are reflected immediately on the visualization, anything we can do to avoid hitting users with error messages and asking them to perform unnecessary additional actions is preferable in my opinion. As such, I like the idea of automatically changing an invalid For example, in the case of a user entry of |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on Chrome, the behavior is aligned with the comments from the PR. code lgtm 🆗
… values (elastic#110222) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Fixes #105133
This PR adds some validation feedback around the
Number of values
input field for the Top values operation, when the user inputs a value either too high or low.The error message is contextual and an explanation of the fallback is included:
Checklist
Delete any items that are not applicable to this PR.
For maintainers