Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Remove Angular #109774

Merged
merged 79 commits into from
Sep 2, 2021
Merged

[Discover] Remove Angular #109774

merged 79 commits into from
Sep 2, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 24, 2021 •
edited
Loading

Summary

This PR removes all remaining Angular related code hidden in Discover. Due to our Deangularization efforts, it's redundant.

Testing

Everything should work like before

resolves #92573

majagrubic and others added 30 commits July 13, 2021 10:11
@majagrubic
[Discover] Always show multifields if reading from source
da87505
@majagrubic
Add a unit test
dd8bd6b
@majagrubic
Merge branch 'master' into react-router-1
da89edc
@majagrubic
[Discover] Add React router: initial commit
fc1deeb
@majagrubic
Add breadcrumbs
729641e
@majagrubic
Add doc route
d4f5705
@majagrubic
Add badge for readonly
61ba18b
@majagrubic
Remove unused import
0c3f427
@majagrubic
Merge master
3f4438f
@majagrubic
Remove invalid leftover
2ad5f68
@majagrubic
Add missing route
8b7fb8e
@majagrubic
Fix typescript failure
bf3e9c2
@majagrubic
Merge branch 'master' into react-router-1
b470dec
@majagrubic
Fix unmounting issue
a047241
@majagrubic
Fix typescript error
2746c2b
@majagrubic
Remove unused variable
f722b71
@majagrubic
Fix linting errors
cce81bc
@majagrubic
Reload context if anchorId changes
19f3a0d
@majagrubic
Fix DOM structure
87cb6ea
@majagrubic
Add index pattern list
c0c2afb
@majagrubic
Reload state from props
324ac82
@kertal
Merge remote-tracking branch 'upstream/master' into react-router-1
da7f319
@majagrubic
Fix linting error
2ab4860
@majagrubic
Merge branch 'master' into react-router-1
a96a95a
@majagrubic
Merge branch 'master' into react-router-1
029b2cb
@majagrubic
Applying Matthias's changes
4b124df
@majagrubic
Fix wrongly modified file
78ac177
@majagrubic
Attempt at fixing imports?
0870c6f
@majagrubic
Minor polish
6aefd9a
@majagrubic
Fix typescript issue
6d195af
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested review from dimaanj and timroes August 31, 2021 06:49
@kertal kertal mentioned this pull request Aug 31, 2021
Closed
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@timroes timroes requested review from a team and removed request for a team August 31, 2021 14:56
andreadelrio
andreadelrio approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a cool achievement team! LGTM 🚀 🎉

dimaanj
dimaanj approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in FF, LGTM

@kertal
Copy link
Member Author

kertal commented Sep 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 444 438 -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 551.7KB 525.6KB -26.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 92.5KB 89.4KB -3.1KB
Unknown metric groups

async chunk count

id before after diff
discover 6 4 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

timroes
timroes approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via a-la-carte on Chrome Linux. Seems to work fine. Tested Discover main app, surrounding documents, individual document viewer, embeddable on dashboards. Code LGTM

@kertal kertal changed the title [Discover] Remove angular [Discover] Remove Angular Sep 2, 2021
@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 2, 2021
@kertal kertal merged commit 814cf7a into elastic:master Sep 2, 2021
@kibanamachine kibanamachine mentioned this pull request Sep 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 2, 2021
@kertal @kibanamachine
[Discover] Remove Angular (elastic#109774)
65b826d 
- This PR removes a remaining Angular related code in Discover
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kertal kertal mentioned this pull request Sep 2, 2021
Closed
kertal added a commit to kertal/kibana that referenced this pull request Sep 2, 2021
@kertal
[Discover] Remove Angular (elastic#109774)
341d52e 
- This PR removes a remaining Angular related code in Discover
kibanamachine added a commit that referenced this pull request Sep 2, 2021
@kibanamachine @kertal
[Discover] Remove Angular (#109774) (#110980)
13345a4 
- This PR removes a remaining Angular related code in Discover

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
@kertal kertal mentioned this pull request Sep 10, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

@dimaanj dimaanj dimaanj approved these changes

Assignees

@kertal kertal

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application performance release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Deangularize Discover App
7 participants
@kertal @elasticmachine @kibanamachine @timroes @andreadelrio @dimaanj @majagrubic