Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover Document Table Cleanup #10682

Closed
2 of 3 tasks
weltenwort opened this issue Mar 3, 2017 · 1 comment
Closed
2 of 3 tasks

Discover Document Table Cleanup #10682

weltenwort opened this issue Mar 3, 2017 · 1 comment
Assignees
Labels
Feature:Discover Discover Application Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WIP Work in progress

Comments

@weltenwort
Copy link
Member

weltenwort commented Mar 3, 2017

This is a meta ticket to track the progress of the discover document table cleanup, which will be spread across multiple pull requests.

Goals

The goal of this cleanup is to resolve several problems arising from the unfortunate way in which the discover document table is rendered and in which it interacts with other parts of Kibana:

  • displayed information are outdated under certain circumstances (such as highlighting changes Highlighting appears sticky when doc_table is open #9729)
  • incremental enhancements to the table are difficult due to strong coupling between constituents
  • business logic is duplicated and spread throughout the constituents (such as column changes, sorting, etc) making the table rigid and brittle in the face of changes
  • stylesheets are mostly inherited from bootstrap and couple the constituents even stronger
  • rendering code is a mix of angular templates, lodash templates and jquery dom manipulation

After the cleanup the following statements about the document table should be true:

  • the content of the table is always consistent and up-to-date
  • the table is rendered as a hierarchy of clean react components
  • business logic is separate from the view logic
  • stylesheets minimize the coupling by adhering to the BEM convention as introduced by the Kibana ui framework

Progress

@weltenwort weltenwort added Feature:Discover Discover Application :Discovery WIP Work in progress Meta labels Mar 3, 2017
@weltenwort weltenwort self-assigned this Mar 3, 2017
@Bargs Bargs added discuss and removed discuss labels Sep 12, 2017
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure :Discovery labels Sep 16, 2018
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member

kertal commented Sep 10, 2021

closing this since it's nearly 4 years on, lots of changes and mostly angular is gone in the meantime #109774

@kertal kertal closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. WIP Work in progress
Projects
None yet
Development

No branches or pull requests

4 participants