[5.x] Avoid infinite digest loop caused by $watch and $timeout #10119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #10036 **Commit 1:** Avoid infinite digest loop in debounce The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally. * Original sha: 13c677d * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-01-24T11:30:41Z
4ac91d9 to
a5741bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid infinite digest loop caused by $watch and $timeout
Backports PR #10036
Commit 1:
Avoid infinite digest loop in debounce
The custom debounce implementation uses Angular's
$timeout, whichinteracts unfavourably with the unconditional
$watchhandler used inthe
fixed-scrolldirective. It results in an infinite digest beingtriggered about every 100ms. To avoid that, this commit uses the
invokeApplyoption of$timeoutand instead calls$scope.$applyconditionally.