Avoid infinite digest loop caused by $watch and $timeout #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
695b9c1 to
23471b2
Compare
|
jenkins, test this |
|
Test failure looked unrelated. Once they pass this LGTM. We should backport to 5.2 as well. |
Bargs
approved these changes
Jan 27, 2017
|
thanks, @Bargs. The failure seems to be related to the map tile changes. I'll rebase on master and try again. |
The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally.
23471b2 to
13c677d
Compare
weltenwort
added a commit
that referenced
this pull request
Jan 31, 2017
Backports PR #10036 **Commit 1:** Avoid infinite digest loop in debounce The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally. * Original sha: 13c677d * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-01-24T11:30:41Z
weltenwort
pushed a commit
that referenced
this pull request
Jan 31, 2017
Backports PR #10036 **Commit 1:** Avoid infinite digest loop in debounce The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally. * Original sha: 13c677d * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-01-24T11:30:41Z
weltenwort
added a commit
that referenced
this pull request
Jan 31, 2017
Backports PR #10036 **Commit 1:** Avoid infinite digest loop in debounce The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally. * Original sha: 13c677d * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-01-24T11:30:41Z
weltenwort
pushed a commit
that referenced
this pull request
Jan 31, 2017
Backports PR #10036 **Commit 1:** Avoid infinite digest loop in debounce The custom debounce implementation uses Angular's `$timeout`, which interacts unfavourably with the unconditional `$watch` handler used in the `fixed-scroll` directive. It results in an infinite digest being triggered about every 100ms. To avoid that, this commit uses the `invokeApply` option of `$timeout` and instead calls `$scope.$apply` conditionally. * Original sha: 13c677d * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2017-01-24T11:30:41Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9326 introduced the usage of a custom
debounceimplementation in thefixed-scrolldirective used for the discover table. That customdebounceimplementation uses Angular's$timeout, which interacts unfavourably with the unconditional$watchhandler used in thefixed-scrolldirective. It results in a digest being triggered about every 100ms, even when the page is otherwise idle:$watchstarts$timeout$timeoutelapses, triggers a digestPreventing
debouncefrom always triggering a digest cycle in combination with an explicit$applydoes not exhibit that behaviour:It also avoids some additional digest cycles when the scroll width has not changed.