Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Create an autocomplete component #161763

Closed
guskovaue opened this issue Jul 12, 2023 · 1 comment
Closed

[RAM] Create an autocomplete component #161763

guskovaue opened this issue Jul 12, 2023 · 1 comment
Assignees
@guskovaue
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0

Comments

@guskovaue
Copy link
Contributor

guskovaue commented Jul 12, 2023 •
edited
Loading

Meta task: #158183

Create an autocomplete components on top of our markdown editor
_ Take inspiration form this POC -> elastic/eui#5885 _
@guskovaue guskovaue added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 labels Jul 12, 2023
@guskovaue guskovaue self-assigned this Jul 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@guskovaue guskovaue changed the title Create an autocomplete component [RAM] Create an autocomplete component Jul 12, 2023
@guskovaue guskovaue moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Jul 12, 2023
@guskovaue guskovaue mentioned this issue Jul 12, 2023
Merged
@guskovaue guskovaue moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Aug 28, 2023
XavierM added a commit that referenced this issue Aug 31, 2023
@guskovaue @kibanamachine @XavierM
[RAM] Autocomplete (#158454)
0af40a3 
## Summary

Solves this issue: #161763

This PR introduces autocomplete for mustache variables for email
connector(next PR will add it to all connectors) under the feature flag.

We decided keep old solution with button with all searchable options as
well.

How to test:
Create an email connector in kibana.yml:

xpack.actions.preconfigured:
  maildev:
    name: 'email: maildev'
    actionTypeId: '.email'
    config:
      from: 'guskova@example.com'
      host: 'localhost'
      port: '1025'

How it should work:
You start writing in Message window {{ and mustache variable name. And
you should see autocomplete popup with all possible options to choose.
When you click somewhere else, popup should disappeared.


https://github.com/elastic/kibana/assets/26089545/061016a6-b8ca-497b-9bed-b8b012d31a95

e options to choose. When you click somewhere else, popup should
disappeared.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this issue Aug 31, 2023
@guskovaue @kibanamachine
@XavierM @eokoneyo
[RAM] Autocomplete (elastic#158454)
2f12334 
## Summary

Solves this issue: elastic#161763

This PR introduces autocomplete for mustache variables for email
connector(next PR will add it to all connectors) under the feature flag.

We decided keep old solution with button with all searchable options as
well.

How to test:
Create an email connector in kibana.yml:

xpack.actions.preconfigured:
  maildev:
    name: 'email: maildev'
    actionTypeId: '.email'
    config:
      from: 'guskova@example.com'
      host: 'localhost'
      port: '1025'

How it should work:
You start writing in Message window {{ and mustache variable name. And
you should see autocomplete popup with all possible options to choose.
When you click somewhere else, popup should disappeared.


https://github.com/elastic/kibana/assets/26089545/061016a6-b8ca-497b-9bed-b8b012d31a95

e options to choose. When you click somewhere else, popup should
disappeared.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guskovaue guskovaue

Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

RAM-158244-autocomplete-component-for-action-msg guskovaue/kibana
2 participants
@elasticmachine @guskovaue