-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiMarkdownEditor] Markdown mentions #5885
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview documentation changes for this PR: https://eui.elastic.co/pr_5885/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5885/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5885/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5885/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PROPOSAL
SPEC: #5829
Curent statuses:
Temporary caveats:
Summary
markdown_mentions_prototype.mov
Given a configuration,
src-docs/src/views/markdown_editor/markdown_editor.js
this parses @... as a
mentionsPlugin
node, passing the configuration options to an EuiSelectable while the textarea retains focus. The popover component attaches keyboard listeners to the textarea to handle up/down arrows, enter, and escape keys to manipulate the selectable component. The renderer renders the mentioned name and, if it matches a config option, adds thefirst
name value as a tooltip.Checklist
Checklist