Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Change "Drop last bucket" to "Drop partial bucket" #14681

Closed
Tracked by #179671
ycombinator opened this issue Oct 31, 2017 · 5 comments
Closed
Tracked by #179671

[TSVB] Change "Drop last bucket" to "Drop partial bucket" #14681

ycombinator opened this issue Oct 31, 2017 · 5 comments
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ycombinator
Copy link
Contributor

Currently in TSVB's Panel Options, there is an option to "Drop last bucket" which defaults to true/yes. Chatting with @simianhacker the intent behind this option was to drop partial buckets.

I think we can make the UX a bit better by exposing this intent directly, by changing the text to "Drop partial bucket" instead. Then the implementation could actually figure out if the last bucket was a partial bucket (with some date math and comparing the bucket's upper bound to the time picker's upper bound) and drop it if the user wants.
@ycombinator ycombinator added the Feature:TSVB TSVB (Time Series Visual Builder) label Oct 31, 2017
@shaharmor
Copy link
Contributor

Woudl also be good to add it to the first bucket

@timroes timroes added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Feb 12, 2018
simianhacker added a commit that referenced this issue Apr 11, 2018
@simianhacker
[TSVB] Introducing Timerange Data Mode for Metric Style Visualizations
db33bef 
- Adds timerange data mode for table, guage, metric and top n
- Changes query for metric style vis to only query last 5 buckets unless
there is a sibling agg
- Request and response are now included in api response
- Fixed table header EUI upgrade
- Fixed wrapping for top n
- Fixing tests
- Fixes #14681 - Change the behavior of drop last bucket to drop partial bucket
- Move index pattern out of panel options; adding info component
- Removing panel property from AggSelect
- Defaulting to EUI standards for code style
- Updating modal to EUI writing guidlines
- Renaming functions to be more clear
- Adding date math since yarn was complaining
- Fixin the logic for truncated timerange
- Fixing outdated tests
- Adjusting tests to new feature
- Updating to latest EUI
simianhacker added a commit to simianhacker/kibana that referenced this issue Apr 16, 2018
@simianhacker
[TSVB] Introducing Timerange Data Mode for Metric Style Visualizations
9445702 
- Adds timerange data mode for table, guage, metric and top n
- Changes query for metric style vis to only query last 5 buckets unless
there is a sibling agg
- Request and response are now included in api response
- Fixed table header EUI upgrade
- Fixed wrapping for top n
- Fixing tests
- Fixes elastic#14681 - Change the behavior of drop last bucket to drop partial bucket
- Move index pattern out of panel options; adding info component
- Removing panel property from AggSelect
- Defaulting to EUI standards for code style
- Updating modal to EUI writing guidlines
- Renaming functions to be more clear
- Adding date math since yarn was complaining
- Fixin the logic for truncated timerange
- Fixing outdated tests
- Adjusting tests to new feature
- Updating to latest EUI
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@timroes timroes added the enhancement New value added to drive a business result label Feb 4, 2019
@odmby
Copy link

odmby commented Oct 25, 2020

will this happen?
having a hard time with the first bucket always causing huge spikes or drops

@timroes timroes mentioned this issue Mar 11, 2021
Closed
@ghudgins ghudgins mentioned this issue Dec 1, 2021
Closed
@rmetzger
Copy link

I'm also affected by this. A fix would be much appreciated.

@kostasb
Copy link

kostasb commented Mar 23, 2022 •
edited
Loading

@ghudgins Is there any chance this issue could be considered for a bugfix release? I am confident it has been affecting TSVB users all around but since it's transient it is likely hard to report.

It makes some TSVB time series visualizations look buggy depending on the momentary time bucket results.

It is pretty easy to reproduce, here's an example (on 7.17.1):

image

After a reload, using the same timerange (last 3 hours) only a few seconds later:

image

The visualization is a derivative on sum of counters, using a fixed 1m interval.

image

Unsure if there could be something else lurking around causing this behavior though.

@timductive timductive mentioned this issue Mar 28, 2024
Open
@timductive
Copy link
Member

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@timductive timductive closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ycombinator @rmetzger @timroes @timductive @shaharmor @kostasb @odmby