-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus package to leverage types in remote write #243
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Pinging @elastic/integrations-platforms (Team:Platforms) |
Wondering about versioning on this https://github.com/elastic/integrations/pull/243/files#diff-7fc71a4e1d864fb27e0913069d72da8dR4. Should it be a patch upgrade or a minor number update since it introduces new functionality? |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
cc: @exekias |
@ChrsMark I think you need to rebase this PR against the master branch. |
@mtojek the feature is implemented in Beats in |
I assume that the package-storage distribution for 7.9 has been freezed and we're safe to commit changes for 7.10. @ruflin, right? |
The 7.9 branch has not been created yet. But that should not hold back this PR. If the package is only compatible with 7.10, please ensure it contains the correct conditions. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@exekias could you please have a final look on this since I applied some changes 🙂 ? |
What does this PR do?
Updates Prometheus package to leverage types in remote write.
Checklist
Related issues
Screenshots