Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus package to leverage types in remote write #243

Merged
merged 10 commits into from
Aug 31, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Aug 11, 2020

What does this PR do?

Updates Prometheus package to leverage types in remote write.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

Screenshots

Screenshot 2020-08-11 at 15 12 03

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this Aug 11, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations-platforms (Team:Platforms)

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@elasticmachine
Copy link

elasticmachine commented Aug 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #243 updated]

  • Start Time: 2020-08-31T13:21:33.210+0000

  • Duration: 3 min 26 sec

@ChrsMark
Copy link
Member Author

Wondering about versioning on this https://github.com/elastic/integrations/pull/243/files#diff-7fc71a4e1d864fb27e0913069d72da8dR4. Should it be a patch upgrade or a minor number update since it introduces new functionality?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

cc: @exekias

@mtojek
Copy link
Contributor

mtojek commented Aug 24, 2020

@ChrsMark I think you need to rebase this PR against the master branch.

@ChrsMark
Copy link
Member Author

@mtojek the feature is implemented in Beats in 7.10 version. In this, is it ok to merge this package update now, or shall we wait? What is the process in such cases?

@mtojek
Copy link
Contributor

mtojek commented Aug 31, 2020

I assume that the package-storage distribution for 7.9 has been freezed and we're safe to commit changes for 7.10. @ruflin, right?

@ruflin
Copy link
Contributor

ruflin commented Aug 31, 2020

The 7.9 branch has not been created yet. But that should not hold back this PR. If the package is only compatible with 7.10, please ensure it contains the correct conditions.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from exekias August 31, 2020 11:11
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

@exekias could you please have a final look on this since I applied some changes 🙂 ?

@ChrsMark ChrsMark merged commit c1a765d into elastic:master Aug 31, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants