-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer types in Prometheus remote_write API #17675
Comments
Pinging @elastic/integrations-platforms (Team:Platforms) |
would love your thoughts here @ChrsMark |
Sounds good @exekias! Only note here that this extra "compute" step might have an impact in the performance of remote endpoint. In this we might add an option to disable this type casting if users do not actually need it. Wondering regarding Point 2 if it would be useful in cases with a lot of timeseries? Would the users be willing to customize that much? |
Right now
tbh I'm not sure, I would expect a regexp to be fast enough |
Describe the enhancement:
We introduced different type behavior (use_types, rate_counters) when using Prometheus collector in 7.7. It would be nice to offer something similar for metrics coming through
remote_write
, for consistency and users profit.Remote write API schema is typeless so we would need some heuristics to detect the original type where needed. For instance:
_bucket
with ale
label are part of a histogram.*_total
are counters. We could make this a configurable regexp list, so users can tweak it to its needs.The text was updated successfully, but these errors were encountered: