Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for advanced indexing features #227

Merged
merged 5 commits into from
May 26, 2023

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented May 25, 2023

This adds documentation to enable and disable advanced indexing features: TSDS and synthetic _source.

@kpollich Thanks for the really excellent draft! I made only very minor changes.

Rel: #151

PREVIEW

@kilfoyle kilfoyle marked this pull request as draft May 25, 2023 22:30
@kilfoyle kilfoyle marked this pull request as ready for review May 26, 2023 14:10
@andresrc
Copy link

andresrc commented May 26, 2023

AFAIK, as of 8.8.0 these features are no longer experimental. If this is correct, I'd probably go "Advanced Indexing Features" or something like that and remove the technical preview banner /cc @joshdover @ruflin

Edit: clarified at #227 (comment) . In any case, this comment is not blocking we can always fine tune in follow-up PRs

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this change on my end. It is key that we have the page, now we can start to iterate on it with smaller PR's / changes.

@kilfoyle
Copy link
Contributor Author

@andresrc

AFAIK, as of 8.8.0 these features are no longer experimental...

Coincidentally, I worked on the TSDS docs. The feature is GA. I think all that matters is that the synthetic source docs (in the Elasticsearch guide) are marked with the admonition, and they are:
Screenshot 2023-05-26 at 10 44 20 AM

So I've removed the technical preview banner from this page, and I've changed all instances of experimental to advanced.

@lalit-satapathy lalit-satapathy changed the title Add docs for experimental indexing features Add docs for advanced indexing features May 26, 2023
Copy link

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the first cut version. We will add any tweaks needed in future docs PR.

@kilfoyle
Copy link
Contributor Author

Thanks for thorough and super fast reviews!

I'll merge and backport this into 8.8, and I'm happy to help iterate on whatever updates we still need.

@kilfoyle
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kilfoyle added a commit to kilfoyle/ingest-docs that referenced this pull request May 26, 2023
* Add docs for experimental indexing features

* Fixup

* Address review feedback

* Update example rollover POST request

* Reverse link order

(cherry picked from commit c511416)
kilfoyle added a commit that referenced this pull request May 26, 2023
* Add docs for experimental indexing features

* Fixup

* Address review feedback

* Update example rollover POST request

* Reverse link order

(cherry picked from commit c511416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants