-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Provide docs for experimental indexing features #151
Comments
Testing these recommendations as-is on 8.8.0-snapshot, finding errors. Can we cross-test and update the recommendation, so that they can be blindly copied to work as-is for any end user?
But works for: null
|
Which integration was TSDB attempted to be enabled for? I'd like to try and reproduce this. This sounds like it may be intended behavior based on the manifest for the integration.
Fixed in the description above. |
Trying on nginx latest package; this is the specific command used, Let me know, if I should be following different steps? Can you check the same once.
Thanks! |
I see the same behavior on the nginx package. Fleet doesn't actually generate the @juliaElastic @nchaulet - you both worked in this area. Does anything stand out about the Nginx package in particular that might ring a bell here? I took a look and I think this may be a bug we need to look into on the Fleet side but I'm not 100% sure. |
@kpollich actually Fleet do not put the |
Seems like I run into the same error trying to update the index template, e.g.
|
@kpollich I think you may two issue here the PUT need to have the whole index template with the
|
Got it - thanks. I'll update the description here to make this clear. |
This seems to be the root cause of the issue on the Looking at the code, Fleet will only append @nchaulet - Do you think we could change Fleet such that we always generate |
We could try it we had some issues with adding |
I removed the conditions to prevent dimension/metric settings from being generated for mappings unless |
It may be worth running the |
The issue seems to occur in other integrations with dimensions (ex: oracle). You can check completed packages here. |
I remember it had some side effects in Elasticsearch on older versions but as Kibana and Elasticsearch should be on the same version, this should work as expected. @kpollich Being able to roll back is critical for enabling TSDB. As the toggles are not "visible" anymore, the custom path must work. |
Follow up thought: To make sure we are aligned, the expectation is that before and after enabling / disabling TSDB, the template is 100% the same, only the setting changes. This applies to dimensions but also the metric types and potential other things we add. |
Hi @kpollich, Can you help summarise where we stand today, on the following?
|
Hi @lalit-satapathy, I'll summarize below. I've filed elastic/integrations#6128 which fixes invalid mappings on the GCP and Elastic Package Registry integrations. I'm waiting on codeowner review from obs-cloud-monitoring and the SEI teams before I can merge this. The PR above blocks elastic/kibana#157047 which is the root cause fix for the enable/disable TSDB issue we see here. I've pinged both teams above for codeowner review but will ping in Slack if I don't hear anything soon.
I am not sure what you're asking here. We haven't discovered any new issues as far as I'm aware. |
I should mention elastic/kibana#157345 actually, which is still in the early stages but I believe the team has tracked down the root issue. |
Can we use the "Disable TSDS" manual option now, since this is fixed? |
Posting a long explanation around still getting the
Seems like Elasticsearch isn't inferring
I tried setting this on the index template level as well with the same error
The same thing happens in the UI when I try to enable TSDB for this data stream via the toggles
So, either something has regressed in Elasticsearch around the inference of the Interestingly, I was able to toggle TSDB on for the
However executing the exact same request via dev tools results in a failure
And once I get this error from dev tools, I can no longer toggle the TSDB setting via the UI Looking at the two payloads (one previously successful generated by the Fleet API and one from dev tools), there's one major difference: the one generated by the TSDB toggle/Fleet API has
If you include this, everything works as expected. So, Elasticsearch won't generate |
tl;dr of the above: we need to update the API requests to
I'll take care of this now and verify everything is working end-to-end |
Updated description + tested synthetic source + TSDS instructions. Everything worked as expected. cc @lalit-satapathy |
Testing manual TSDB disabling for nginx. TSDB disablement and rollover seems to work fine.
CC @tetianakravchenko to check on k8 package. |
@lalit-satapathy - Looks great to me. Thanks for testing and for your patience as we fix up bugs here 🙏 |
@karenzone could you please add this to your radar for your next sprint content? |
@kilfoyle could you please start working on this issue as soon as you can? We are close from the TSDB official launch and it would be great to see this documented. |
@jlind23 Will do. 👍 |
Thanks @kilfoyle can you keep @lalit-satapathy in the loop or ping him if you need help, our priority is having a place we can send customers to show how to disable TSDB should a problem occur. |
@kilfoyle do we have any ETA for this? We have the first packages ready to ship. |
@kpollich, @lalit-satapathy, the docs page is ready for review via PR #227 There's a preview link in the PR description. @andresrc I'll have the docs PR merged as soon as I can (ideally today or Monday) and will update this issue. |
The docs page is live: I assume we can close this issue now. I'm happy to help with whatever revisions we need. |
Ref elastic/kibana#132818
Fleet currently supports experimental indexing features behind a feature flag and via some (contentious) UI toggles. We'd like to remove the toggles entirely and simply allow advanced users (or those trialing prerelease integrations) to enable/disable these features via the component template API.
We'd like to add some docs for how to do this, though it may make sense to hide them as they aren't designed for general consumption. The approach here will be for the observability team to work with certain users to trial new versions of integrations that make heavy use of these features, and they need some docs they can link to to get some of the setup out of the way.
I've drafted some docs below:
Enabling and disabling experimental indexing features for Fleet-managed data streams
Fleet provides support for several experimental features around its data streams including
_source
- LinkThese features can be enabled and disabled for Fleet-managed data streams via the index template API and a few key settings.
Note: If you are already making use of
@custom
component templates for ingest/retention customization (e.g. Tutorial: Customize data retention policies), you should exercise care and ensure you don't overwrite your customizations when making these requests.It is recommended to execute the following requests via Kibana dev tools. Replace
<NAME>
with the name of a given integration data stream, e.g.metrics-nginx.stubstatus
would result in making aPUT
request to_component_template/metrics-nginx.stubstatus@custom
. Use the index management interface to explore what integration data streams are available to you.Once you've executed a given request below, you'll also need to execute a data stream rollover to ensure any incoming data is ingested with your new settings immediately, e.g.
Enabling synthetic
_source
Disabling synthetic
_source
Enabling TSDS
Note: TSDS utilizes synthetic
_source
under the hood, so if you want to trial both features you only need to enable TSDSTSDS must be enabled at the index template level, due to restrictions in the Elasticsearch API. So, you'll need to make some sequential requests to enable or disable TSDB.
Disabling TSDS
Disabling TSDS follows the same procedure as above, but specifying
null
forindex.mode
instead oftime_series
, e.g.cc @andresrc @mlunadia @lalit-satapathy @ruflin
The text was updated successfully, but these errors were encountered: