Remove TS types from exports when they come from node_modules #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
reviewed
Aug 1, 2019
| // comes from a 3rd-party library | ||
| // best way to reliably check if this is | ||
| // a type or value is to require the | ||
| // library and check it's exports |
There was a problem hiding this comment.
Interesting. I didn't notice any increase in build time, but I'd expect this method to take longer, I guess.
There was a problem hiding this comment.
It only executes for export {} from '' statements, which we don't really do with node_modules libraries.
We've had |
thompsongl
approved these changes
Aug 1, 2019
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
…c#2191) * Remove TS types from exports when they come from node_modules * changelog * Remove debugger statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2185 by filtering out non-value exports from
node_modulesduring build/babel. I tested by:esdirectory before-and-after this change, only components/drag_and_drop/index.js had changesnpm packed version of EUI with these changesChecklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes