Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types exported directly from react-beautiful-dnd are not removed in ES build #2185

Closed
thompsongl opened this issue Jul 31, 2019 · 0 comments · Fixed by #2191
Closed

Types exported directly from react-beautiful-dnd are not removed in ES build #2185

thompsongl opened this issue Jul 31, 2019 · 0 comments · Fixed by #2191
Assignees
@chandlerprall

Comments

@thompsongl
Copy link
Contributor

Results in an import error in consuming applications that don't import @types/react-beautiful-dnd or don't use TS.

https://github.com/elastic/eui/blob/master/src/components/drag_and_drop/index.ts#L6-L16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandlerprall chandlerprall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TS types from exports when they come from node_modules chandlerprall/eui
2 participants
@chandlerprall @thompsongl