Better names and types for ingest stats #93533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
masseyke
reviewed
Feb 7, 2023
|
|
||
| static final String TYPE = "on_failure"; | ||
|
|
||
| public OnFailureProcessor(boolean ignoreFailure, Processor processor, List<Processor> onFailureProcessors) { |
There was a problem hiding this comment.
I don't think we have any test coverage (in OnFailureProcessorTests or IngestStatsNamesAndTypesIT) for when onFailureProcessors is not empty, do we? Might also be worth documenting that that is non-empty if there is an on_failure block, and empty if ignore_failure = true.
There was a problem hiding this comment.
I pulled this out into its own PR, see #93573.
masseyke
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80763
Follow up to #93483
Adds a specialized internal
OnFailureProcessorwrapper that formalizeson_failureandignore_failurehandling, and then adds unwrapping of that class when we calculate stats (similar to howConditionalProcessoris already unwrapped). The result is greatly improved clarity and consistency for the names and types that we report for ingest stats.