Add a new test of the current behavior for ingest pipeline names and types #93483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Ahhhhh, well, that's unfortunate. My test passes in isolation, but the yml tests all bang on the same cluster, and the other ingest yml tests pollute the global cluster stats processor count, so this test can't check call counts the way I want it to. I guess I'll rewrite this as an IT or something then, but it won't be quite as pretty. |
|
Alrighty, now it's a java test. If you look closely at the bytes of the test, you can see how annoyed I am about this. 😄 |
masseyke
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #80763
This test is pretty much a crystallization of my earlier comment there (#80763 (comment)) into a yml test. (edit: yml didn't work out, now it's a java test.)
Note: none of this is meant to say the current behavior is desirable, it's just capturing that this is what the current behavior happens to be.
I'm doing this as a separate PR so that the diff on my next PR will show how the behavior has changed, and make an even stronger case for why that PR is a good solution to the problem of the above-linked issue.