-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade geoip2 dependency #93522
Upgrade geoip2 dependency #93522
Conversation
They're proper modules now.
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM. (good to merge, from my POV) Just a note on the addition of
[1] https://github.com/maxmind/GeoIP2-java/blob/43c354f22410d1ef58f26c2653c619853c373bef/CHANGELOG.md?plain=1#L26 |
Yeah, that's my understanding. We download the files ourselves and then manage them locally via indexes and files, from the POV of the geoip library, there's no downloading to do. |
See https://github.com/maxmind/GeoIP2-java/releases and https://github.com/maxmind/MaxMind-DB-Reader-java/releases.
Pretty straightforward version bumps all around.