Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for jdk module dependencies to be added to individual plugins #93553

Open
pgomulka opened this issue Feb 7, 2023 · 1 comment
Open
Labels
>bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team

Comments

@pgomulka
Copy link
Contributor

pgomulka commented Feb 7, 2023

Elasticsearch Version

8

Installed Plugins

No response

Java Version

bundled

OS Version

macos

Problem Description

At the moment if es module (gradle) or plugin are declaring a java9 module dependency in module-info.java and that dependency is from the jdk's module it will not work.
That dependency currently has to be added to server's module-info too.
example:
ingest-geoip module-info

module org.elasticsearch.ingest.geoip {
    requires org.elasticsearch.base;
    requires org.elasticsearch.server;
    requires org.elasticsearch.xcontent;
    requires org.apache.logging.log4j;
    requires org.apache.lucene.core;
    requires com.maxmind.geoip2;
    requires com.maxmind.db;

com.maxmind.geoip2 module-info

module com.maxmind.geoip2 {
    requires com.fasterxml.jackson.annotation;
    requires com.fasterxml.jackson.databind;
    requires com.maxmind.db;
    requires java.net.http;

so in order for this to work, we have to add java.net.http into server's module-info.
as per comment #93522 (comment) it could be fixed

Steps to Reproduce

.

Logs (if relevant)

No response

@pgomulka pgomulka added >bug needs:triage Requires assignment of a team area label labels Feb 7, 2023
@HiDAl HiDAl added :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Feb 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

3 participants