Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Added more clear english sentence for task api detailed param #88493

Merged
merged 2 commits into from
Jul 14, 2022
Merged

[DOCS] Added more clear english sentence for task api detailed param #88493

merged 2 commits into from
Jul 14, 2022

Conversation

amitmbm
Copy link
Contributor

@amitmbm amitmbm commented Jul 13, 2022

Fix for #88469

@elasticsearchmachine elasticsearchmachine added v8.4.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 13, 2022
@amitmbm
Copy link
Contributor Author

amitmbm commented Jul 13, 2022

@DaveCTurner Please review, Thanks in advance :)

@amitmbm @DaveCTurner
Update docs/reference/cluster/tasks.asciidoc
9204f85 
Co-authored-by: David Turner <david.turner@elastic.co>
@stu-elastic stu-elastic added the >docs General docs changes label Jul 13, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 13, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@stu-elastic stu-elastic added the :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. label Jul 13, 2022
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 13, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@pxsalehi pxsalehi self-assigned this Jul 14, 2022
@pxsalehi pxsalehi self-requested a review July 14, 2022 07:17
pxsalehi
pxsalehi approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@pxsalehi pxsalehi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pxsalehi pxsalehi merged commit 1147396 into elastic:master Jul 14, 2022
pxsalehi added a commit that referenced this pull request Jul 14, 2022
@pxsalehi
Revert "Improve description for task api detailed param (#88493)"
2f72e99 
This reverts commit 1147396.
@lockewritesdocs lockewritesdocs changed the title #88469 Added more clear english sentence for task api detailed param [DOCS] Added more clear english sentence for task api detailed param Jul 14, 2022
@pxsalehi
Copy link
Member

pxsalehi commented Jul 14, 2022 •
edited
Loading

The revert commit referenced above was an accident. Nothing was reverted!

pxsalehi pushed a commit to pxsalehi/elasticsearch that referenced this pull request Jul 14, 2022
@amitmbm @DaveCTurner @pxsalehi
[DOCS] Improve description for task api detailed param (elastic#88493)
55052ee 
Co-authored-by: David Turner <david.turner@elastic.co>
@pxsalehi pxsalehi mentioned this pull request Jul 14, 2022
Merged
@amitmbm amitmbm deleted the fix-88469 branch July 14, 2022 12:52
pxsalehi added a commit that referenced this pull request Jul 14, 2022
@pxsalehi @amitmbm @DaveCTurner
[DOCS] Improve description for task api detailed param (#88493) (#88546)
5f5a48c 
Co-authored-by: Elasticsearch addict <amitmbm87@gmail.com>
Co-authored-by: David Turner <david.turner@elastic.co>
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 15, 2022
@weizijun
Merge branch 'upstream/master' into number-support-single-type
0d878ac 
* upstream/master: (2974 commits)
  Reserved cluster state service (elastic#88527)
  Add transport action immutable state checks (elastic#88491)
  Remove suggest flag from index stats docs (elastic#85479)
  Polling cluster formation state for master-is-stable health indicator (elastic#88397)
  Add test execution guide in yamlRestTest asciidoc (elastic#88490)
  Add troubleshooting guide for corrupt repository (elastic#88391)
  [Transform] Finetune Schedule to be less noisy on retry and retry slower (elastic#88531)
  Updatable API keys - auto-update legacy RDs (elastic#88514)
  Fix typo in TransportForceMergeAction and TransportClearIndicesCacheA… (elastic#88064)
  Fixed NullPointerException on bulk request (elastic#88358)
  Avoid needless index metadata builders during reroute (elastic#88506)
  Set metadata on request in API key noop test (elastic#88507)
  Fix passing positional args to ES in Docker (elastic#88502)
  Improve description for task api detailed param (elastic#88493)
  Support cartesian shape with doc values (elastic#88487)
  Promote usage of Subjects in Authentication class (elastic#88494)
  Add CCx 2.0 feature flag (elastic#88451)
  Reword the watcher 'always' and 'never' condition docs (elastic#86105)
  Simplify azure discovery installation docs (elastic#88404)
  Breakup FIPS CI testing jobs
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
#	x-pack/plugin/mapper-aggregate-metric/src/main/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapper.java
@DaveCTurner
Copy link
Contributor

Thanks @amitmbm & @pxsalehi!

@idegtiarenko idegtiarenko mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner left review comments

@pxsalehi pxsalehi pxsalehi approved these changes

Assignees

@pxsalehi pxsalehi

Labels
:Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amitmbm @elasticmachine @pxsalehi @DaveCTurner @stu-elastic @elasticsearchmachine