Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword the watcher 'always' and 'never' condition docs #86105

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Reword the watcher 'always' and 'never' condition docs #86105

merged 5 commits into from
Jul 14, 2022

Conversation

crispybacon
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 22, 2022 •
edited
Loading

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added v8.1.4 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 22, 2022
@crispybacon
Copy link
Contributor Author

I have signed the contributor agreement.

@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels May 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo self-assigned this May 19, 2022
@joegallo joegallo changed the base branch from 8.1 to master May 19, 2022 18:25
@joegallo joegallo changed the base branch from master to 8.1 May 19, 2022 18:25
@joegallo joegallo changed the base branch from 8.1 to master May 19, 2022 18:28
@joegallo joegallo changed the title Setting these values to True or False results in an error. Reword the watcher 'always' and 'never' condition docs May 19, 2022
@joegallo joegallo added v8.3.0 and removed v8.1.4 labels May 19, 2022
debadair
debadair reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions, otherwise LGTM.

@joegallo @debadair
Apply suggestions from code review
921c1d0 
Co-authored-by: debadair <debadair@elastic.co>
@joegallo joegallo requested a review from debadair May 19, 2022 22:11
debadair
debadair approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@debadair debadair merged commit 4000878 into elastic:master Jul 14, 2022
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 15, 2022
@weizijun
Merge branch 'upstream/master' into number-support-single-type
0d878ac 
* upstream/master: (2974 commits)
  Reserved cluster state service (elastic#88527)
  Add transport action immutable state checks (elastic#88491)
  Remove suggest flag from index stats docs (elastic#85479)
  Polling cluster formation state for master-is-stable health indicator (elastic#88397)
  Add test execution guide in yamlRestTest asciidoc (elastic#88490)
  Add troubleshooting guide for corrupt repository (elastic#88391)
  [Transform] Finetune Schedule to be less noisy on retry and retry slower (elastic#88531)
  Updatable API keys - auto-update legacy RDs (elastic#88514)
  Fix typo in TransportForceMergeAction and TransportClearIndicesCacheA… (elastic#88064)
  Fixed NullPointerException on bulk request (elastic#88358)
  Avoid needless index metadata builders during reroute (elastic#88506)
  Set metadata on request in API key noop test (elastic#88507)
  Fix passing positional args to ES in Docker (elastic#88502)
  Improve description for task api detailed param (elastic#88493)
  Support cartesian shape with doc values (elastic#88487)
  Promote usage of Subjects in Authentication class (elastic#88494)
  Add CCx 2.0 feature flag (elastic#88451)
  Reword the watcher 'always' and 'never' condition docs (elastic#86105)
  Simplify azure discovery installation docs (elastic#88404)
  Breakup FIPS CI testing jobs
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
#	x-pack/plugin/mapper-aggregate-metric/src/main/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapper.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadair debadair debadair approved these changes

Assignees

@joegallo joegallo

Labels
:Data Management/Watcher >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crispybacon @elasticmachine @debadair @craigtaverner @joegallo @jtibshirani @elasticsearchmachine