Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of dynamic field names #27255

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Add an example of dynamic field names #27255

merged 1 commit into from
Nov 3, 2017

Conversation

loekvangool
Copy link

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

dakrone
dakrone approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you want to merge this @loekvangool or should I?

@dakrone dakrone added >docs General docs changes v6.0.1 v6.1.0 v7.0.0 labels Nov 3, 2017
@loekvangool loekvangool merged commit 67e677f into master Nov 3, 2017
@loekvangool
Copy link
Author

@dakrone Not sure if the tags mean that the PR will be merged with those specific branches? If so, I though I'd mention that this PR does also work in 5.x.

@dakrone
Copy link
Member

dakrone commented Nov 3, 2017

@loekvangool those indicate which branches this PR should be merged to, so if it goes to 5.6 then it should be merged to: master, 6.x, 6.0, and 5.6

@dakrone dakrone added the v5.6.5 label Nov 3, 2017
dakrone pushed a commit that referenced this pull request Nov 3, 2017
@dakrone
Add an example of dynamic field names (#27255)
d4849df
dakrone pushed a commit that referenced this pull request Nov 3, 2017
@dakrone
Add an example of dynamic field names (#27255)
5a0eafe
dakrone pushed a commit that referenced this pull request Nov 3, 2017
@dakrone
Add an example of dynamic field names (#27255)
e0faf36
@dakrone
Copy link
Member

dakrone commented Nov 3, 2017

I went ahead and cherry-picked this to the respective branches

@loekvangool loekvangool deleted the loekvangool-patch-7 branch November 3, 2017 22:41
martijnvg added a commit that referenced this pull request Nov 4, 2017
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
e61e4b8 
* es/master:
  Fix snapshot getting stuck in INIT state (#27214)
  Add an example of dynamic field names (#27255)
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix InternalStatsTests
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
martijnvg added a commit that referenced this pull request Nov 4, 2017
@martijnvg
Merge branch '6.x' into ccr-6.x
3ed5aaa 
* 6.x:
  Add an example of dynamic field names (#27255)
  fixed checkstyle violation
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  [TEST] Fix failing exists query test
  test: Do not run old parent/child tests against a cluster with minimum version greater than 6.0.0
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  fix compil after backport
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v5.6.5 v6.0.1 v6.1.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loekvangool @dakrone @colings86