Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDR to ip_range #26260

Closed
eskibars opened this issue Aug 17, 2017 · 2 comments
Closed

CIDR to ip_range #26260

eskibars opened this issue Aug 17, 2017 · 2 comments
Labels
>enhancement help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@eskibars
Copy link
Contributor

Describe the feature:
Currently the ip_range type accepts the standard range notation (e.g. gte, lte). However, IP ranges are fairly commonly defined by a CIDR. It adds some complexity to the mapping internally, but in order to avoid having to do the conversion externally when the source data may come directly from e.g. a network switch and also to cut down on the overall size of _source, it may be nice to support the implicit conversion.

@eskibars eskibars added :Search Foundations/Mapping Index mappings, including merging and defining field types discuss >enhancement labels Aug 17, 2017
@s1monw s1monw added help wanted adoptme and removed discuss labels Aug 18, 2017
@s1monw
Copy link
Contributor

s1monw commented Aug 18, 2017

we discussed it in fixit firday and we are convinced we should do this. Not sure about the priority. I am labeling it adopt me.

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Nov 3, 2017
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Nov 3, 2017
dakrone pushed a commit that referenced this issue Nov 3, 2017
*  #26260 Allow ip_range to accept CIDR notation

*  #26260 added non-byte-alligned cidr test cases
dakrone pushed a commit that referenced this issue Nov 3, 2017
*  #26260 Allow ip_range to accept CIDR notation

*  #26260 added non-byte-alligned cidr test cases
@dakrone
Copy link
Member

dakrone commented Nov 3, 2017

Fixed in #27192

@dakrone dakrone closed this as completed Nov 3, 2017
martijnvg added a commit that referenced this issue Nov 4, 2017
* es/master:
  Fix snapshot getting stuck in INIT state (#27214)
  Add an example of dynamic field names (#27255)
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix InternalStatsTests
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
martijnvg added a commit that referenced this issue Nov 4, 2017
* 6.x:
  Add an example of dynamic field names (#27255)
  fixed checkstyle violation
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  [TEST] Fix failing exists query test
  test: Do not run old parent/child tests against a cluster with minimum version greater than 6.0.0
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  fix compil after backport
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Development

No branches or pull requests

4 participants