Remove Log4j 1 jar hell exemption #20336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Elasticsearch depended on Log4j 1, there was jar hell from the log4j and the apache-log4j-extras jar. As these dependencies are gone, the jar hell exemption for Log4j 1 can be removed.
* master: Add test for Log4j throwable proxy leniency Skip loading of jansi from log4j2 (#20334)
|
retest this please |
|
LGTM |
|
retest this please |
|
Thanks @nik9000. |
MaineC
pushed a commit
to MaineC/elasticsearch
that referenced
this pull request
Sep 7, 2016
When Elasticsearch depended on Log4j 1, there was jar hell from the log4j and the apache-log4j-extras jar. As these dependencies are gone, the jar hell exemption for Log4j 1 can be removed. Relates elastic#20336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Elasticsearch depended on Log4j 1, there was jar hell from the
log4j and the apache-log4j-extras jar. As these dependencies are gone,
the jar hell exemption for Log4j 1 can be removed.
Relates #20235