Skip loading of jansi from log4j2 #20334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jython shades `jansi` into it's classpath without changing it's package or anything like that. This causes attempts to load native code on windows which blows up tests. This change adds `log4j.skipJansi=true` system property to our tests as well as to the JVM properties we set.
|
I was curious why this is only a problem on Windows. The relevant Log4j code has this: if (!propsUtil.isOsWindows() || propsUtil.getBooleanProperty("log4j.skipJansi") || direct) {
return outputStream;
}and otherwise proceeds to try to load Jansi. Since this is only useful for console color support on Windows, and we will never supply the jar anyway, the change is good. LGTM. |
|
Thanks for contributing to Elasticsearch @s1monw, I've merged this pull request. Keep them coming! |
MaineC
pushed a commit
to MaineC/elasticsearch
that referenced
this pull request
Sep 7, 2016
Jython shades `jansi` into it's classpath without changing it's package or anything like that. This causes attempts to load native code on windows which blows up tests. This change adds `log4j.skipJansi=true` system property to our tests as well as to the JVM properties we set.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jython shades
jansiinto it's classpath without changing it's package oranything like that. This causes attempts to load native code on windows which
blows up tests. This change adds
log4j.skipJansi=truesystem property to ourtests as well as to the JVM properties we set.
@jasontedor can you take a look