Add support for hiragana_uppercase & katakana_uppercase token filters in kuromoji analysis plugin #106553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in kuromoji analysis plugin
|
Pinging @elastic/es-search (Team:Search) |
|
Builds are failing due to the two new token filters created via: apache/lucene#12915 Since the original idea was to expose those in ES, I decided to do that and fix the failing test. |
|
The test failure is fixed by: apache/lucene#13195 Will rerun CI once new snapshot is pulled in. |
…s/lucene_snapshot
|
Thanks Ben! LGTM. |
daixque
added a commit
to daixque/elasticsearch
that referenced
this pull request
Aug 29, 2024
New filters are: - hiragana_uppercase - katakana_uppercase This is related to: * elastic#106553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
hiragana_uppercaseandkatakana_uppercaseprovided in the new lucene release.Sutegana (捨て仮名) is small letter of hiragana and katakana in Japanese. In the old Japanese text, sutegana (捨て仮名) is not used unlikely to modern one. For example:
So it's meaningful to normalize sutegana to normal (uppercase) characters if we search against the corpus which includes old Japanese text such as patents, legal documents, contract policies, etc.
Related to: apache/lucene#12915