Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for when fields are missing in searchNearestVectors #13195

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

benwtrent
Copy link
Member

Related to: #13162

Since this is unreleased, no changelog entry is necessary.

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ChrisHegarty
Copy link
Contributor

Was this behaviour regressed by #13162? I wonder if a test would be warranted to ensure that it does not reoccur. Also, in some areas fi.getVectorDimension() == 0 was also checked at the same time.

@benwtrent
Copy link
Member Author

@ChrisHegarty added a test :)

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benwtrent. LGTM

@benwtrent benwtrent merged commit d5f8853 into apache:main Mar 20, 2024
3 checks passed
@benwtrent benwtrent deleted the bugfix/fix-npe-on-field-missing branch March 20, 2024 15:49
benwtrent added a commit that referenced this pull request Mar 20, 2024
Related to: #13162

Since this is unreleased, no changelog entry is necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants